Difference between revisions of "Flag Days"

From coreboot
Jump to: navigation, search
(Cosmetic changes, and add example code fixes.)
Line 4: Line 4:
  
 
== r5152: Change in PS/2 keyboard API ==
 
== r5152: Change in PS/2 keyboard API ==
 +
 +
Applicable if: local changes/additions to Super I/Os.
  
 
The [http://www.coreboot.org/pipermail/coreboot/2010-February/056012.html name and function prototype of the PS/2 keyboard initialization function changed]:
 
The [http://www.coreboot.org/pipermail/coreboot/2010-February/056012.html name and function prototype of the PS/2 keyboard initialization function changed]:
Line 19: Line 21:
 
  -init_pc_keyboard('''res0->base, res1->base''', &conf->keyboard);
 
  -init_pc_keyboard('''res0->base, res1->base''', &conf->keyboard);
 
  +pc_keyboard_init(&conf->keyboard);
 
  +pc_keyboard_init(&conf->keyboard);
 +
 +
== r5162: Move crt0s away from user servicable parts in the build system ==
 +
 +
Applicable if: local changes/additions to mainboards
 +
 +
The crt0s variable in the buildsystem, which collects the various parts that are combined to crt0.o, is [http://www.coreboot.org/pipermail/coreboot/2010-February/056062.html setup generically] now.
 +
 +
This change must be replicated with local mainboard changes/additions. It should be enough to simply '''remove all crt0s entries''' from <code>src/mainboard/$(MAINBOARDDIR)/Makefile.inc</code>.
 +
 +
If you want to check the behaviour:
 +
* apply the Makefile patch (which adds the printcrt0s rule) to your tree
 +
* run "make printcrt0s", note the result
 +
* apply the entire patch
 +
* run "make printcrt0s", and compare the results

Revision as of 17:10, 25 February 2010

This page collects sweeping changes on the tree that might have an impact on boards that weren't tested by the developer, or on uncommitted development. It's sorted by revision (and thus date) and provides a Changelog to anyone who needs to update older trees.

To prevent inaccuracies, changes prior to the creation of this page aren't logged. The head revision at the time of creation of this page was r5151.

r5152: Change in PS/2 keyboard API

Applicable if: local changes/additions to Super I/Os.

The name and function prototype of the PS/2 keyboard initialization function changed:

-void init_pc_keyboard(unsigned port0, unsigned port1, struct pc_keyboard *kbd);
+void pc_keyboard_init(struct pc_keyboard *keyboard);

This dismisses the first two arguments (which had to be the constant values 0x60, 0x64 before). This should only have an impact on locally developed Super I/O code that might require to follow this change. The changes required for porting old code are usually of the form:

-init_pc_keyboard(0x60, 0x64, 0);
+pc_keyboard_init(0);

or

-init_pc_keyboard(res0->base, res1->base, &conf->keyboard);
+pc_keyboard_init(&conf->keyboard);

r5162: Move crt0s away from user servicable parts in the build system

Applicable if: local changes/additions to mainboards

The crt0s variable in the buildsystem, which collects the various parts that are combined to crt0.o, is setup generically now.

This change must be replicated with local mainboard changes/additions. It should be enough to simply remove all crt0s entries from src/mainboard/$(MAINBOARDDIR)/Makefile.inc.

If you want to check the behaviour:

  • apply the Makefile patch (which adds the printcrt0s rule) to your tree
  • run "make printcrt0s", note the result
  • apply the entire patch
  • run "make printcrt0s", and compare the results