User talk:Eocallaghan: Difference between revisions

From coreboot
Jump to navigation Jump to search
No edit summary
Line 16: Line 16:
! Family
! Family
|-
|-
| Bobcat architecture (2011)
! K10 architecture (2011)
| Llano || ???
|-
! Bobcat architecture (2011)
| Ontario || f14
| Ontario || f14
|-
|-
Line 28: Line 31:
| Hondo  || f14
| Hondo  || f14
|-
|-
| Piledriver architecture (2012)
! Piledriver architecture (2012)
| Trinity || f15tn
| Trinity || f15tn
|-
|-
Line 34: Line 37:
| Richland || f15rl
| Richland || f15rl
|-
|-
! Jaguar architecture (2013)
| Kabini || f16
|-
|
| Temash || f16
|}
|}



Revision as of 20:29, 23 May 2014

You can find me floating in #coreboot as funfunctor

Sections deserving their own page


AGESA family table

AMD AGESA map
Arch Name Model Name Family
K10 architecture (2011) Llano ???
Bobcat architecture (2011) Ontario f14
Zacate f14
Desna f14
Hondo f14
Piledriver architecture (2012) Trinity f15tn
Richland f15rl
Jaguar architecture (2013) Kabini f16
Temash f16

Current Activities

  • Clean up superio support.
  • Fix DSDT/SSDT in AGESA

AGESA - DSDT/SSDT

Current list of issues below:

Error 6126: syntax error, ***

Notes:

We may extract and decompile the first SSDT table in the following way:

cat /sys/firmware/acpi/tables/SSDT1 > ssdt.dd ; iasl -d ssdt.dd

A snip of the broken code fragment in question is given:

If (LEqual (Local2, 0x07))
{
    If (CondRefOf (\_SB.ALIC, Local6))
    {
        Store (ShiftLeft (Add (Arg0, 0x02), 0x03), Local1)
        \_SB.ALIC (Local1, 0x00, Sleep (0x02), \_SB.ALIC (Local1, 0x01, Store (0x00, 
            Local3), Store (0x01, Local2), Continue, Store (0x04, Local2)), If (LEqual (Local2, 
            0x05))
            {
                Store (0x01, Local4)
                Store (0x00, Local2)
                A074 (Arg0, 0x02)
            }, If (LEqual (Local2, 0x00))
            {
                Store (0x01, A017) /* \_SB_.A017 */
                A029 ()
                Store (0x08, Local2)
            })
    }
}


Currently AGESA has pre-compiled a bunch of .esl files into:

src/vendorcode/amd/agesa/f14/Proc/GNB/PCIe/Family/0x14/F14PcieAlibSsdt.h

This array of pre-compiled SSDT bytecode is used to construct the SSDT table in:

src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbPcieAlibV1/PcieAlib.c

in the function:

AGESA_STATUS PcieAlibBuildAcpiTable ( IN AMD_CONFIG_PARAMS *StdHeader, OUT VOID  **AlibSsdtPtr ) { .. }

The root of SSDT seems to be in the file: vendorcode/amd/agesa/f14/Proc/GNB/PCIe/Family/0x14/F14PcieAlib.esl

We can work around the broken SSDT in mainboard support by maing the following changes to this line in acpi_tables.c:

- alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
+ // alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
+ alib = NULL;

A full diagnostic report is given:

Test 2 of 2: Disassemble and reassemble SSDT
 
Checking ACPI table SSDT (#0)
 
FAILED [HIGH] AMLAsmASL_MSG_SYNTAX: Test 2, Assembler error in line 1151
Line | AML source
--------------------------------------------------------------------------------
01148| If (CondRefOf (\_SB.ALIC, Local6))
01149| {
01150| Store (ShiftLeft (Add (Arg0, 0x02), 0x03), Local1)
01151| \_SB.ALIC (Local1, 0x00, Sleep (0x02), \_SB.ALIC (Local1, 0x01, Store (0x00,
| ^
| Error 6126: syntax error, unexpected PARSEOP_SLEEP, expecting ',' or ')'
01152| Local3), Store (0x01, Local2), Continue, Store (0x04, Local2)), If (LEqual (Local2,
01153| 0x05))
01154| {
================================================================================
:
ADVICE: (for Error #6126, ASL_MSG_SYNTAX): The disassembled code cannot be
reassembled using the strict IASL compiler as it contains syntax errors.
 
FAILED [HIGH] AMLAsmASL_MSG_SYNTAX: Test 2, Assembler error in line 1152
Line | AML source
--------------------------------------------------------------------------------
01149| {
01150| Store (ShiftLeft (Add (Arg0, 0x02), 0x03), Local1)
01151| \_SB.ALIC (Local1, 0x00, Sleep (0x02), \_SB.ALIC (Local1, 0x01, Store (0x00,
01152| Local3), Store (0x01, Local2), Continue, Store (0x04, Local2)), If (LEqual (Local2,
| ^
| Error 6126: syntax error, unexpected PARSEOP_CONTINUE, expecting ',' or ')'
01153| 0x05))
01154| {
01155| Store (0x01, Local4)
================================================================================
 
ADVICE: (for Error #6126, ASL_MSG_SYNTAX): The disassembled code cannot be
reassembled using the strict IASL compiler as it contains syntax errors.
 
FAILED [HIGH] AMLAsmASL_MSG_SYNTAX: Test 2, Assembler error in line 1152
Line | AML source
--------------------------------------------------------------------------------
01149| {
01150| Store (ShiftLeft (Add (Arg0, 0x02), 0x03), Local1)
01151| \_SB.ALIC (Local1, 0x00, Sleep (0x02), \_SB.ALIC (Local1, 0x01, Store (0x00,
01152| Local3), Store (0x01, Local2), Continue, Store (0x04, Local2)), If (LEqual (Local2,
| ^
| Error 6126: syntax error, unexpected ')'
01153| 0x05))
01154| {
01155| Store (0x01, Local4)
================================================================================
 
ADVICE: (for Error #6126, ASL_MSG_SYNTAX): The disassembled code cannot be
reassembled using the strict IASL compiler as it contains syntax errors.
 
FAILED [HIGH] AMLAsmASL_MSG_SYNTAX: Test 2, Assembler error in line 1158
Line | AML source
--------------------------------------------------------------------------------
01155| Store (0x01, Local4)
01156| Store (0x00, Local2)
01157| A074 (Arg0, 0x02)
01158| }, If (LEqual (Local2, 0x00))
| ^
| Error 6126: syntax error, unexpected ','
01159| {
01160| Store (0x01, A017) /* \_SB_.A017 */
01161| A029 ()
================================================================================
 
ADVICE: (for Error #6126, ASL_MSG_SYNTAX): The disassembled code cannot be
reassembled using the strict IASL compiler as it contains syntax errors.
 
FAILED [HIGH] AMLAsmASL_MSG_SYNTAX: Test 2, Assembler error in line 1163
Line | AML source
--------------------------------------------------------------------------------
01160| Store (0x01, A017) /* \_SB_.A017 */
01161| A029 ()
01162| Store (0x08, Local2)
01163| })
| ^
| Error 6126: syntax error, unexpected ')'
01164| }
01165| }
01166| }
================================================================================
 
ADVICE: (for Error #6126, ASL_MSG_SYNTAX): The disassembled code cannot be
reassembled using the strict IASL compiler as it contains syntax errors.
 
FAILED [HIGH] SyntaxCheckIASLCompilerAborted: Test 2, Compilation aborted early
due to a parser detected syntax error.
 
ADVICE: Some subsequent errors may not be detected because the compiler had to
terminate prematurely. If the compiler did not abort early then potentially
correct code may parse incorrectly producing some or many false positive errors.
 
Table SSDT (0) reassembly: Found 5 errors, 0 warnings, 0 remarks.

Remark 2089: Object is not referenced

./src/southbridge/amd/cimx/sb800/acpi/fch.asl:	CreateDWordField(Arg3,0,CDW1)
./src/southbridge/amd/cimx/sb800/acpi/fch.asl:	CreateDWordField(Arg3,4,CDW2)
./src/southbridge/amd/cimx/sb800/acpi/fch.asl:	CreateDWordField(Arg3,8,CDW3)
Checking ACPI table DSDT (#0)

FAILED [LOW] AMLAsmASL_MSG_NOT_REFERENCED: Test 1, Assembler remark in line 1793
Line | AML source
--------------------------------------------------------------------------------
01790|             Method (_OSC, 4, NotSerialized)  // _OSC: Operating System Capabilities
01791|             {
01792|                 CreateDWordField (Arg3, Zero, CDW1)
01793|                 CreateDWordField (Arg3, 0x04, CDW2)
     |                                                 ^
     | Remark 2089: Object is not referenced    (Name is within method [_OSC])
01794|                 CreateDWordField (Arg3, 0x08, CDW3)
01795|                 If (LEqual (Arg0, Buffer (0x10)
01796|                         {
================================================================================
FAILED [LOW] AMLAsmASL_MSG_NOT_REFERENCED: Test 1, Assembler remark in line 1794
Line | AML source
--------------------------------------------------------------------------------
01791|             {
01792|                 CreateDWordField (Arg3, Zero, CDW1)
01793|                 CreateDWordField (Arg3, 0x04, CDW2)
01794|                 CreateDWordField (Arg3, 0x08, CDW3)
     |                                                 ^
     | Remark 2089: Object is not referenced    (Name is within method [_OSC])
01795|                 If (LEqual (Arg0, Buffer (0x10)
01796|                         {
01797|                             /* 0000 */   0x5B, 0x4D, 0xDB, 0x33, 0xF7, 0x1F, 0x1C, 0x40,
================================================================================
Table DSDT (0) reassembly: Found 0 errors, 0 warnings, 2 remarks.