[coreboot-gerrit] Patch merged into coreboot/master: 22bbb69 ASRock E350M1: mainboard.c: Include `cimx_util.h` for `pm_iowrite`

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 1 21:06:40 CEST 2013

the following patch was just integrated into master:
commit 22bbb6942181771381081ef88089552a0408754a
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Mar 29 15:39:54 2013 +0100

    ASRock E350M1: mainboard.c: Include `cimx_util.h` for `pm_iowrite`
    When building the ASRock E350M1, the following warning is shown.
        $ make # on Jenkins (build server)
            CC         mainboard/asrock/e350m1/mainboard.ramstage.o
        src/mainboard/asrock/e350m1/mainboard.c: In function 'mainboard_enable':
        src/mainboard/asrock/e350m1/mainboard.c:63:2: warning: implicit declaration of function 'pm_iowrite' [-Wimplicit-function-declaration]
    This warning was introduced by moving the initialization of the
    ASF registers using `pm_iowrite` to `mainboard.c` in
        commit db6c5bfd8bdef4489e7fec533cb2ca8ae6c24cf3
        Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
        Date:   Thu Mar 21 22:21:28 2013 +0100
            Asrock E350M1: Use SPD read code from F14 wrapper
            Reviewed-on: http://review.coreboot.org/2875
    and is fixed by including `southbridge/amd/cimx/cimx_util.h`
    declaring `pm_iowrite`.
    Note, that the other AMD SB800 based boards seem to use the
    header file `southbridge/amd/sb800/sb800.h`, so no warning is shown
    for those. But since the CIMx SB800 code is used, the routines
    from the CIMx directory are more appropriate to declare these functions.
    So delete the commented out include line for this header too.
    Change-Id: I179aad5157c5a91294339a3e7b6c4c1715c6f099
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2957
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Sat Mar 30 15:25:18 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Mon Apr  1 21:06:39 2013, giving +2
See http://review.coreboot.org/2957 for details.


More information about the coreboot-gerrit mailing list