[coreboot-gerrit] Patch merged into coreboot/master: cd966dd ASRock E350M1: mptable.c: Include `cpu/amd/amdfam14.h` for `get_bus_conf`

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 1 21:07:32 CEST 2013

the following patch was just integrated into master:
commit cd966dd075c5dbe5987bf8618d0ebe430cc331ac
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Mar 29 20:20:56 2013 +0100

    ASRock E350M1: mptable.c: Include `cpu/amd/amdfam14.h` for `get_bus_conf`
    When building the ASRock E350M1, the following warning is shown.
        $ make # on Jenkins (build server)
            CC         mainboard/asrock/e350m1/mptable.ramstage.o
        src/mainboard/asrock/e350m1/mptable.c: In function 'smp_write_config_table':
        src/mainboard/asrock/e350m1/mptable.c:58:3: warning: implicit declaration of function 'get_bus_conf' [-Wimplicit-function-declaration]
    Including the header file `cpu/amd/amdfam14.h` declaring the
    function addresses this warning.
    The same change was done in the following commit for the
    AMD Persimmon board.
        commit d7a696d0f229abccc95ff411f28d91b9b796ab74
        Author: efdesign98 <efdesign98 at gmail.com>
        Date:   Thu Sep 15 15:24:26 2011 -0600
            Persimmon updates for AMD F14 rev C0
            Reviewed-on: http://review.coreboot.org/137
    Change-Id: I7912571fa57f6512b10fc9b5845427fcb6eb50c0
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2966
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Fri Mar 29 21:37:57 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Mon Apr  1 21:07:30 2013, giving +2
See http://review.coreboot.org/2966 for details.


More information about the coreboot-gerrit mailing list