[coreboot-gerrit] Patch merged into coreboot/master: 0499da9 ASRock E350M1: buildOpts.c: Add missing memory related defines

gerrit at coreboot.org gerrit at coreboot.org
Tue Apr 2 18:59:31 CEST 2013

the following patch was just integrated into master:
commit 0499da98859332b739f2ee5ea3329f6f57b4db96
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Mar 29 19:55:56 2013 +0100

    ASRock E350M1: buildOpts.c: Add missing memory related defines
    When building the ASRock E350M1, the following warnings are shown.
        $ make # on Jenkins (build server)
            CC         mainboard/asrock/e350m1/buildOpts.romstage.o
        In file included from src/mainboard/asrock/e350m1/buildOpts.c:294:0:
        src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h:2071:6: warning: "DDR1333_FREQUENCY" is not defined [-Wundef]
        src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h:2071:40: warning: "DDR1866_FREQUENCY" is not defined [-Wundef]
        src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h:2089:5: warning: "TIMING_MODE_AUTO" is not defined [-Wundef]
        src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h:2089:31: warning: "TIMING_MODE_SPECIFIC" is not defined [-Wundef]
        src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h:2113:5: warning: "QUADRANK_UNBUFFERED" is not defined [-Wundef]
        src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h:2113:33: warning: "QUADRANK_UNBUFFERED" is not defined [-Wundef]
        src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h:2127:5: warning: "POWER_DOWN_BY_CHIP_SELECT" is not defined [-Wundef]
        src/vendorcode/amd/agesa/f14/Include/PlatformInstall.h:2127:28: warning: "POWER_DOWN_BY_CHIP_SELECT" is not defined [-Wundef]
    Adding the corresponding defines as done for AMD Persimmon in
        commit d7a696d0f229abccc95ff411f28d91b9b796ab74
        Author: efdesign98 <efdesign98 at gmail.com>
        Date:   Thu Sep 15 15:24:26 2011 -0600
            Persimmon updates for AMD F14 rev C0
            Reviewed-on: http://review.coreboot.org/137
    addresses the warnings.
    Change-Id: Id311b2dacdba5f2e6b4d834e43db0310213a35f9
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2962
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martin.roth at se-eng.com>

Build-Tested: build bot (Jenkins) at Fri Mar 29 20:16:28 2013, giving +1
Reviewed-By: Martin Roth <martin.roth at se-eng.com> at Tue Apr  2 06:07:58 2013, giving +2
See http://review.coreboot.org/2962 for details.


More information about the coreboot-gerrit mailing list