[coreboot-gerrit] New patch to review for coreboot: bb9f69b AMD GX1: Remove useless copied header file `northbridge.h`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Thu Apr 4 02:01:03 CEST 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3020


commit bb9f69b987d14edf40a6a7237bb57ae7b6e95ed9
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Thu Apr 4 01:50:17 2013 +0200

    AMD GX1: Remove useless copied header file `northbridge.h`
    This was there since the beginning
        commit d24d6993b6d7bcf7977d74d081e718e1b076d1b0
        Author: arch import user (historical) <svn at openbios.org>
        Date:   Wed Jul 6 17:06:46 2005 +0000
            Revision: linuxbios at linuxbios.org--devel/freebios--devel--2.0--patch-26
            Creator:  Hamish Guthrie <hamish at prodigi.ch>
            Added AMD GX1 northbridge and cs5530 Southbridge
    but blindly copied from Intel 440 BX and is not used anywhere.
    Thanks to Idwer Vollering for spotting this.
    Change-Id: I38b3d3feb25966c3aa382994d323e59c3f3c9e6c
    Reported-by: Idwer Vollering
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/northbridge/amd/gx1/northbridge.c | 1 -
 src/northbridge/amd/gx1/northbridge.h | 6 ------
 2 files changed, 7 deletions(-)

diff --git a/src/northbridge/amd/gx1/northbridge.c b/src/northbridge/amd/gx1/northbridge.c
index 4547b8d..d670a19 100644
--- a/src/northbridge/amd/gx1/northbridge.c
+++ b/src/northbridge/amd/gx1/northbridge.c
@@ -6,7 +6,6 @@
 #include <device/pci_ids.h>
 #include <stdlib.h>
 #include <string.h>
-#include "northbridge.h"
 #include <cpu/amd/gx1def.h>
 #include <cpu/x86/cache.h>
 #include <cpu/cpu.h>
diff --git a/src/northbridge/amd/gx1/northbridge.h b/src/northbridge/amd/gx1/northbridge.h
deleted file mode 100644
index 3e569bb..0000000
--- a/src/northbridge/amd/gx1/northbridge.h
+++ /dev/null
@@ -1,6 +0,0 @@
-extern unsigned int i440bx_scan_root_bus(device_t root, unsigned int max);
-#endif /* NORTHBRIDGE_INTEL_440BX_H */

More information about the coreboot-gerrit mailing list