[coreboot-gerrit] Patch merged into coreboot/master: 33e83ca cbfstool: completely initialize input and output streams

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 8 21:36:42 CEST 2013


the following patch was just integrated into master:
commit 33e83caff59f7b6ff2ba62d3b496235ef5c4e543
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Mon Apr 8 11:20:55 2013 -0700

    cbfstool: completely initialize input and output streams
    
    The LZMA glue code in cbfstool was recently rewritten from C++
    to plain C code in:
    
            commit aa3f7ba36ebe3a933aa664f826382f60b31e86f1
            Author: Stefan Reinauer <reinauer at chromium.org>
            Date:   Thu Mar 28 16:51:45 2013 -0700
    
                cbfstool: Replace C++ code with C code
    
                Reviewed-on: http://review.coreboot.org/3010
    
    In the progress of doing so, the stream position for the
    input stream and output stream was not reset properly. This
    would cause LZMA producing corrupt data when running the
    compression function multiple times.
    
    Change-Id: I096e08f263aaa1931517885be4610bbd1de8331e
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
    Reviewed-on: http://review.coreboot.org/3040
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Mon Apr  8 21:33:33 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Mon Apr  8 21:36:37 2013, giving +2
See http://review.coreboot.org/3040 for details.

-gerrit



More information about the coreboot-gerrit mailing list