[coreboot-gerrit] Patch merged into coreboot/master: cfb7360 replace device/i2c.h with simpler version

gerrit at coreboot.org gerrit at coreboot.org
Tue Apr 9 23:59:36 CEST 2013

the following patch was just integrated into master:
commit cfb73607be05e57237592c5c94a98589aba04833
Author: David Hendricks <dhendrix at chromium.org>
Date:   Fri Apr 5 13:42:39 2013 -0700

    replace device/i2c.h with simpler version
    The existing header was imported along with the Exynos code and left
    mostly unchanged. This is the first patch in a series intended to
    replace the imported u-boot I2C API with a much simpler and cleaner
    - We only need to expose i2c_read() and i2c_write() in our public API.
      Everything else is board/chip-dependent and should remain hidden
    - i2c_read and i2c_write functions will take bus number as an arg
      and we'll eliminate i2c_get_bus and i2c_set_bus. Those are prone to
      error and end up cluttering the code since the user needs to save
      the old bus number, set the new one, do the read/write, and restore
      the old value (3 added steps to do a simple transaction).
    - Stop setting default values for board-specific things like SPD
      and RTC bus numbers (as if we always have an SPD or RTC on I2C).
    - Death to all the trivial inline wrappers. And in case there was any
      doubt, we really don't care about the MPC8xx. Though if we did then
      we would not pollute the public API with its idiosyncrasies.
    Change-Id: I4410a3c82ed5a6b2e80e3d8c0163464a9ca7c3b0
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/3043
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Tue Apr  9 03:45:09 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Tue Apr  9 23:59:34 2013, giving +2
See http://review.coreboot.org/3043 for details.


More information about the coreboot-gerrit mailing list