[coreboot-gerrit] New patch to review for coreboot: 1b5a0ae Snow: Fix the recovery GPIO polarity, and lid GPIO polarity and number.

Gabe Black (gabeblack@chromium.org) gerrit at coreboot.org
Thu Apr 11 00:11:38 CEST 2013


Gabe Black (gabeblack at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3066

-gerrit

commit 1b5a0ae16c77f3d0e9fc80860508afe671a3a205
Author: Gabe Black <gabeblack at chromium.org>
Date:   Wed Apr 10 14:39:09 2013 -0700

    Snow: Fix the recovery GPIO polarity, and lid GPIO polarity and number.
    
    Change-Id: I34097f878291367b28962048190e11ccaacfc514
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
---
 src/mainboard/google/snow/chromeos.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/google/snow/chromeos.c b/src/mainboard/google/snow/chromeos.c
index d29aa2a..015b71e 100644
--- a/src/mainboard/google/snow/chromeos.c
+++ b/src/mainboard/google/snow/chromeos.c
@@ -34,7 +34,7 @@
 #define DEVMODE_GPIO	54
 #define FORCE_RECOVERY_MODE	0
 #define FORCE_DEVELOPER_MODE	0
-#define LID_OPEN	3
+#define LID_OPEN	5
 #define POWER_BUTTON	3
 
 #include <boot/coreboot_tables.h>
@@ -59,15 +59,15 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 	strncpy((char *)gpios->gpios[0].name,"write protect",
 							GPIO_MAX_NAME_LENGTH);
 
-	/* Recovery: active high */
+	/* Recovery: active low */
 	gpios->gpios[1].port = EXYNOS5_GPY1;
-	gpios->gpios[1].polarity = ACTIVE_HIGH;
+	gpios->gpios[1].polarity = ACTIVE_LOW;
 	gpios->gpios[1].value = s5p_gpio_get_value(&gpio_pt1->y1, FORCE_RECOVERY_MODE);
 	strncpy((char *)gpios->gpios[1].name,"recovery", GPIO_MAX_NAME_LENGTH);
 
 	/* Lid: the "switch" comes from the EC */
 	gpios->gpios[2].port = EXYNOS5_GPX3;
-	gpios->gpios[2].polarity = ACTIVE_LOW;
+	gpios->gpios[2].polarity = ACTIVE_HIGH;
 	gpios->gpios[2].value = s5p_gpio_get_value(&gpio_pt2->x3, LID_OPEN);
 	strncpy((char *)gpios->gpios[2].name,"lid", GPIO_MAX_NAME_LENGTH);
 



More information about the coreboot-gerrit mailing list