[coreboot-gerrit] Patch merged into coreboot/master: 573a1d6 Persimmon/Fam14/SB800 DSDT: Split into common areas
gerrit at coreboot.org
gerrit at coreboot.org
Thu Apr 11 21:48:29 CEST 2013
the following patch was just integrated into master:
Author: Mike Loptien <mike.loptien at se-eng.com>
Date: Mon Mar 18 11:19:26 2013 -0600
Persimmon/Fam14/SB800 DSDT: Split into common areas
Split the Persimmon DSDT into common code areas.
For example, split the Southbridge specific code into
the Southbridge directory and CPU specific code into
the CPU directory. Also adding the superio.asl file
to the Persimmon DSDT tree. This file is empty for
the moment but will be necessary in the future. I have
also emptied the thermal.asl file in the mainboard
directory because it does not seem to perform as
intended (fan control does not change when it is
brought back into the code base) and it has been
inside a '#if 0' statement for a long time. Removing
it until it is decided that it is actually necessary.
This change was verified in three different ways:
1. Visual comparison of the compiled DSDT pulled from the
Persimmon after booting into Linux using the ACPI tools
acpidump, acpixtract, and iasl. The comparison was done
between the DSDT before and after doing the split work.
This test is somewhat difficult considering the expanse
of the changes. Blocks of code have been moved, and
2. Linux logs were dumped before and after the DSDT split.
Logs dumped and compared include dmesg and lspci -tv.
Neither log changed significantly between the two compare
3. The test suite FWTS was run on the Coreboot build both
before and after doing the DSDT split with the command
'sudo fwts -b -P -u'. The flag -b specifies all batch jobs,
-P specifies all power tests, and -u specifies utilities.
Interactive jobs were not run as most of them consist of
laptop checks. Again, there were no significant changes
between the two endpoints.
These tests lead me to believe that there was no change in
the functionality of the ACPI tables apart from what is
known and expected.
This patch is the first of a series of patches to split the DSDT.
The ASRock patch was merged before this one and breaks the ASROCK
E350M1 build (patch 8d80a3fb: http://review.coreboot.org/#/c/3050/).
Please be aware of this dependency when pulling these patches.
Other patches that depend on this patch are
'AMD Fam14: Split out the AMD Fam14 DSDT'
and 'Fam14 DSDT: Also return for unrecognized UUID in _OSC'
Signed-off-by: Mike Loptien <mike.loptien at se-eng.com>
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martin.roth at se-eng.com>
Build-Tested: build bot (Jenkins) at Thu Apr 11 21:38:01 2013, giving +1
Reviewed-By: Martin Roth <martin.roth at se-eng.com> at Thu Apr 11 21:48:27 2013, giving +2
See http://review.coreboot.org/3048 for details.
More information about the coreboot-gerrit