[coreboot-gerrit] New patch to review for coreboot: ae4bbae snow: Return 0 from get_recovery_mode_from_vbnv.

Gabe Black (gabeblack@chromium.org) gerrit at coreboot.org
Tue Apr 16 06:01:23 CEST 2013

Gabe Black (gabeblack at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3098


commit ae4bbaec045003d62666ab2e043de24199e54cfd
Author: Gabe Black <gabeblack at chromium.org>
Date:   Mon Apr 15 20:36:01 2013 -0700

    snow: Return 0 from get_recovery_mode_from_vbnv.
    This function isn't yet used for much, or perhaps anything, but where it
    appears in the code it's ored with other values. Since we're not actually
    retrieving anything, it might be best to return 0 so that the other values
    that are being ored in can be expressed and this function can stay dormant
    until it actually has something to do.
    Change-Id: I6edc222a5c2d00ece2ecfad5191a615331eeaf16
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
 src/mainboard/google/snow/chromeos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/snow/chromeos.c b/src/mainboard/google/snow/chromeos.c
index 0c47458..6e46d13 100644
--- a/src/mainboard/google/snow/chromeos.c
+++ b/src/mainboard/google/snow/chromeos.c
@@ -116,5 +116,5 @@ int get_recovery_mode_switch(void)
 int get_recovery_mode_from_vbnv(void)
-	return 1;
+	return 0;

More information about the coreboot-gerrit mailing list