[coreboot-gerrit] Patch set updated for coreboot: 52dd93b snow: Fix the name of some constants in romstage.c.

Gabe Black (gabeblack@chromium.org) gerrit at coreboot.org
Tue Apr 16 06:32:32 CEST 2013


Gabe Black (gabeblack at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3095

-gerrit

commit 52dd93b448032f57c9d8746f78efb36a51fd220d
Author: Gabe Black <gabeblack at chromium.org>
Date:   Mon Apr 15 19:45:10 2013 -0700

    snow: Fix the name of some constants in romstage.c.
    
    These names were inherited from chromeos.c where they've already been
    fixed.
    
    Change-Id: I7ad57b979b7b8f42f6bd68d1ecf887caba3fa3f1
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
---
 src/mainboard/google/snow/romstage.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/mainboard/google/snow/romstage.c b/src/mainboard/google/snow/romstage.c
index dda4e7c..96e93da 100644
--- a/src/mainboard/google/snow/romstage.c
+++ b/src/mainboard/google/snow/romstage.c
@@ -127,8 +127,8 @@ static void chromeos_gpios(void)
 
 	enum {
 		WP_GPIO = 6,
-		FORCE_RECOVERY_MODE = 0,
-		LID_OPEN = 5
+		RECMODE_GPIO = 0,
+		LID_GPIO = 5
 	};
 
 	gpio_pt1 = (struct exynos5_gpio_part1 *)EXYNOS5_GPIO_PART1_BASE;
@@ -137,12 +137,11 @@ static void chromeos_gpios(void)
 	s5p_gpio_direction_input(&gpio_pt1->d1, WP_GPIO);
 	s5p_gpio_set_pull(&gpio_pt1->d1, WP_GPIO, EXYNOS_GPIO_PULL_NONE);
 
-	s5p_gpio_direction_input(&gpio_pt1->y1, FORCE_RECOVERY_MODE);
-	s5p_gpio_set_pull(&gpio_pt1->y1, FORCE_RECOVERY_MODE,
-		EXYNOS_GPIO_PULL_NONE);
+	s5p_gpio_direction_input(&gpio_pt1->y1, RECMODE_GPIO);
+	s5p_gpio_set_pull(&gpio_pt1->y1, RECMODE_GPIO, EXYNOS_GPIO_PULL_NONE);
 
-	s5p_gpio_direction_input(&gpio_pt2->x3, LID_OPEN);
-	s5p_gpio_set_pull(&gpio_pt2->x3, LID_OPEN, EXYNOS_GPIO_PULL_NONE);
+	s5p_gpio_direction_input(&gpio_pt2->x3, LID_GPIO);
+	s5p_gpio_set_pull(&gpio_pt2->x3, LID_GPIO, EXYNOS_GPIO_PULL_NONE);
 }
 
 void main(void)



More information about the coreboot-gerrit mailing list