[coreboot-gerrit] Patch set updated for coreboot: e7d7247 Google/Snow: Remove duplicated SPI1 initialization in bootblock.

Hung-Te Lin (hungte@chromium.org) gerrit at coreboot.org
Tue Apr 30 10:20:46 CEST 2013

Hung-Te Lin (hungte at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3147


commit e7d72473ba665d0639ad8964b10ea007af0fc79e
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Tue Apr 30 16:11:32 2013 +0800

    Google/Snow: Remove duplicated SPI1 initialization in bootblock.
    The firmware media source (SPI1) is already initialized by Exynos iROM.
    There is no need to do it again.
    Verified by building and booting Google/Snow successfully.
    Change-Id: I89390506aa825397c0d7e52ad7503f1cb808f7db
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
 src/mainboard/google/snow/bootblock.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/snow/bootblock.c b/src/mainboard/google/snow/bootblock.c
index 09edbad..fa87203 100644
--- a/src/mainboard/google/snow/bootblock.c
+++ b/src/mainboard/google/snow/bootblock.c
@@ -40,9 +40,14 @@ void bootblock_mainboard_init(void)
 			 * We want to do this as early as we can.
-			exynos_pinmux_config(PERIPH_ID_SPI1, PINMUX_FLAG_NONE);
+	/* For most ARM systems, we have to initialize firmware media source
+	 * (ex, SPI, SD/MMC, or eMMC) now; but for Exynos platform, that is
+	 * already handled by iROM so there's no need to setup again.
+	 */
 	exynos_pinmux_config(PERIPH_ID_UART3, PINMUX_FLAG_NONE);

More information about the coreboot-gerrit mailing list