[coreboot-gerrit] Patch merged into coreboot/master: 032dd14 Google/Snow: Remove unnecessary serial console init code.
gerrit at coreboot.org
gerrit at coreboot.org
Tue Apr 30 19:22:06 CEST 2013
the following patch was just integrated into master:
commit 032dd14514e72777475c3e39395486627846b7c9
Author: Hung-Te Lin <hungte at chromium.org>
Date: Tue Apr 30 15:31:48 2013 +0800
Google/Snow: Remove unnecessary serial console init code.
The "console_init" does initialize UART driver (which will setup peripheral and
pinmux) and print starting message. Duplicated initialization can be removed.
Also, console_init (from console.c) is always linked to bootblock (and will do
nothing if CONFIG_EARLY_CONSOLE is not defined) so it's safe to remove #ifdef.
Verified by building and booting on Google/Snow, with and without
CONFIG_EARLY_CONSOLE.
Change-Id: I0c6b4d4eb1a4e81af0f65bcb032978dfb945c63d
Signed-off-by: Hung-Te Lin <hungte at chromium.org>
Reviewed-on: http://review.coreboot.org/3150
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
Build-Tested: build bot (Jenkins) at Tue Apr 30 11:07:01 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Tue Apr 30 19:22:05 2013, giving +2
See http://review.coreboot.org/3150 for details.
-gerrit
More information about the coreboot-gerrit
mailing list