[coreboot-gerrit] Patch set updated for coreboot: 9360f8c Don't include LZMA in romstage if ramstage is not compressed.

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Aug 19 08:15:31 CEST 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3878

-gerrit

commit 9360f8ccc54ea65a43ed91485eaf411586b3344f
Author: Andrew Wu <arw at dmp.com.tw>
Date:   Mon Aug 19 11:43:36 2013 +0800

    Don't include LZMA in romstage if ramstage is not compressed.
    
    If ramstage is not compressed, the CBFS module in romstage doesn't
    need to support LZMA. Removing the LZMA module in this case can save
    about 3000 bytes in romstage.
    
    Change-Id: Id6f7869e32979080e2985c07029edcb39eee9106
    Signed-off-by: Andrew Wu <arw at dmp.com.tw>
---
 src/lib/Makefile.inc | 2 +-
 src/lib/cbfs.c       | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc
index c421038..90efe6c 100644
--- a/src/lib/Makefile.inc
+++ b/src/lib/Makefile.inc
@@ -42,7 +42,7 @@ endif
 romstage-y += memcmp.c
 rmodules-y += memcmp.c
 romstage-y += cbfs.c
-romstage-y += lzma.c
+romstage-$(CONFIG_COMPRESS_RAMSTAGE) += lzma.c
 #romstage-y += lzmadecode.c
 romstage-$(CONFIG_CACHE_AS_RAM) += ramtest.c
 romstage-$(CONFIG_CONSOLE_SERIAL8250) += uart8250.c
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index f48d887..4ccc9e6 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -29,6 +29,8 @@
 # define CBFS_MINI_BUILD
 #elif defined(__BOOT_BLOCK__)
   /* No LZMA in boot block. */
+#elif defined(__PRE_RAM__) && !CONFIG_COMPRESS_RAMSTAGE
+  /* No LZMA in romstage if ramstage is not compressed. */
 #else
 # define CBFS_CORE_WITH_LZMA
 # include <lib.h>



More information about the coreboot-gerrit mailing list