[coreboot-gerrit] Patch merged into coreboot/master: a2adaeb usbdebug: Only test two possible USB device numbers

gerrit at coreboot.org gerrit at coreboot.org
Sat Aug 24 05:52:04 CEST 2013


the following patch was just integrated into master:
commit a2adaeb68cdecc2bc1185613a11b7d49915883ec
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Aug 12 00:09:21 2013 +0300

    usbdebug: Only test two possible USB device numbers
    
    After an USB device sees USB bus reset on the bus, it will reset to
    device number 0. Per the EHCI debug port specification, a debug
    dongle device may reset to the fixed debug device number of 127 instead.
    Thus there is no need to try device numbers from 1 to 126.
    
    Do a sanity-check on a returned debug descriptor as I experienced
    some USB flash memory to respond on this request with zero-fill data.
    
    Change-Id: I78d58f3dc049cd8c20c6e2aa3a4207ad7e6a6d33
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
    Reviewed-on: http://review.coreboot.org/3861
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at google.com>


See http://review.coreboot.org/3861 for details.

-gerrit



More information about the coreboot-gerrit mailing list