[coreboot-gerrit] Patch set updated for coreboot: 15449fb libpayload: Add missing break statement in coreboot table parsing
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Mon Dec 2 22:11:55 CET 2013
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4252
-gerrit
commit 15449fbf19e2424a2e801e73ce64b55836588d89
Author: Stefan Reinauer <reinauer at chromium.org>
Date: Wed Jun 19 12:06:50 2013 -0700
libpayload: Add missing break statement in coreboot table parsing
Otherwise the code would try to parse GPIOs when encountering
a mainboard entry in the coreboot table. This never caused any
problems because the mainboard entry is parsed before the GPIO
entry.
Signed-off-by: Stefan Reinauer <reinauer at google.com>
Change-Id: I1443bda8585a990a39115743d48304ec4b54bccb
Reviewed-on: https://gerrit.chromium.org/gerrit/59292
Reviewed-by: Ronald G. Minnich <rminnich at chromium.org>
Commit-Queue: Stefan Reinauer <reinauer at google.com>
Tested-by: Stefan Reinauer <reinauer at google.com>
---
payloads/libpayload/arch/armv7/coreboot.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/payloads/libpayload/arch/armv7/coreboot.c b/payloads/libpayload/arch/armv7/coreboot.c
index 414b7fa..b6178f7 100644
--- a/payloads/libpayload/arch/armv7/coreboot.c
+++ b/payloads/libpayload/arch/armv7/coreboot.c
@@ -250,6 +250,7 @@ static int cb_parse_header(void *addr, int len, struct sysinfo_t *info)
#endif
case CB_TAG_MAINBOARD:
info->mainboard = (struct cb_mainboard *)ptr;
+ break;
#ifdef CONFIG_CHROMEOS
case CB_TAG_GPIO:
cb_parse_gpios(ptr, info);
More information about the coreboot-gerrit
mailing list