[coreboot-gerrit] New patch to review for coreboot: f10544a Added structure members x_mm and y_mm to edid decoding

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Dec 3 22:41:42 CET 2013


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4382

-gerrit

commit f10544a56b23e0128992b553db4bf36ba6cbef77
Author: Furquan Shaikh <furquan at google.com>
Date:   Tue Jul 23 15:53:02 2013 -0700

    Added structure members x_mm and y_mm to edid decoding
    
    Change-Id: I9a628cec4da127a3f072d9611259dad99dfa9d29
    Reviewed-on: https://gerrit.chromium.org/gerrit/63125
    Reviewed-by: Ronald G. Minnich <rminnich at chromium.org>
    Commit-Queue: Furquan Shaikh <furquan at chromium.org>
    Tested-by: Furquan Shaikh <furquan at chromium.org>
---
 src/include/edid.h | 2 ++
 src/lib/edid.c     | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/include/edid.h b/src/include/edid.h
index 88ce55f..4a2f138 100644
--- a/src/include/edid.h
+++ b/src/include/edid.h
@@ -45,6 +45,8 @@ struct edid {
 	/* used to compute timing for graphics chips. */
 	unsigned char phsync;
 	unsigned char pvsync;
+	unsigned int x_mm;
+	unsigned int y_mm;
 	unsigned int pixel_clock;
 	unsigned int link_clock;
 	unsigned int ha;
diff --git a/src/lib/edid.c b/src/lib/edid.c
index 8018967..dd7c46a 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -449,6 +449,8 @@ detailed_block(struct edid *out, unsigned char *x, int in_extension)
 	if (! did_detailed_timing){
 		/* Edid contains pixel clock in terms of 10KHz */
 		out->pixel_clock = (x[0] + (x[1] << 8)) * 10;
+		out->x_mm = (x[12] + ((x[14] & 0xF0) << 4));
+		out->y_mm = (x[13] + ((x[14] & 0x0F) << 8));
 		out->ha = (x[2] + ((x[4] & 0xF0) << 4));
 		out->hbl = (x[3] + ((x[4] & 0x0F) << 8));
 		out->hso = (x[8] + ((x[11] & 0xC0) << 2));
@@ -524,8 +526,8 @@ detailed_block(struct edid *out, unsigned char *x, int in_extension)
 	       "               %04x %04x %04x %04x vborder %x\n"
 	       "               %chsync %cvsync%s%s %s\n",
 	       out->pixel_clock,
-	       (x[12] + ((x[14] & 0xF0) << 4)),
-	       (x[13] + ((x[14] & 0x0F) << 8)),
+	       out->x_mm,
+	       out->y_mm,
 	       out->ha, out->ha + out->hso, out->ha + out->hso + out->hspw,
 	       out->ha + out->hbl, out->hborder,
 	       out->va, out->va + out->vso, out->va + out->vso + out->vspw,



More information about the coreboot-gerrit mailing list