[coreboot-gerrit] New patch to review for coreboot: db8d0f2 exynos5420: Configure the UART pins unconditionally
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Tue Dec 3 23:57:04 CET 2013
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4457
-gerrit
commit db8d0f294723f44193d031362d252cc986b208cb
Author: Gabe Black <gabeblack at google.com>
Date: Fri Aug 9 00:31:09 2013 -0700
exynos5420: Configure the UART pins unconditionally
Configure the pins for the UART unconditionally in the mainboard code (when we
know which UART to configure) instead of in the UART driver. This also means
the UART will work if later software wants to use it without setting up the
pins.
Built and booted on pit with the serial turned off and some serial init
in the kernel decompression stub fixed.
Change-Id: Icab5755e4f935f52d44b9cb3b43d1cb62acce08f
Signed-off-by: Gabe Black <gabeblack at google.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/65299
Reviewed-by: Hung-Te Lin <hungte at chromium.org>
Commit-Queue: Gabe Black <gabeblack at chromium.org>
Tested-by: Gabe Black <gabeblack at chromium.org>
---
src/cpu/samsung/exynos5420/uart.c | 3 ---
src/mainboard/google/pit/romstage.c | 1 +
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/cpu/samsung/exynos5420/uart.c b/src/cpu/samsung/exynos5420/uart.c
index de71b80..c5c8a8c 100644
--- a/src/cpu/samsung/exynos5420/uart.c
+++ b/src/cpu/samsung/exynos5420/uart.c
@@ -93,9 +93,6 @@ static void exynos5_init_dev(void)
{
struct s5p_uart *uart = (struct s5p_uart *)base_port;
- // TODO initialize with correct peripheral id by base_port.
- exynos_pinmux_uart3();
-
/* enable FIFOs */
writel(0x1, &uart->ufcon);
writel(0, &uart->umcon);
diff --git a/src/mainboard/google/pit/romstage.c b/src/mainboard/google/pit/romstage.c
index 853e24d..b74c27f 100644
--- a/src/mainboard/google/pit/romstage.c
+++ b/src/mainboard/google/pit/romstage.c
@@ -250,6 +250,7 @@ void main(void)
* to re-initialize serial console drivers again. */
system_clock_init();
+ exynos_pinmux_uart3();
console_init();
setup_power(is_resume);
More information about the coreboot-gerrit
mailing list