[coreboot-gerrit] Patch set updated for coreboot: 31f8817 Pit: set PWM to external on Parade

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu Dec 12 22:13:00 CET 2013


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4363

-gerrit

commit 31f8817aea2c91bede5d119b20defc61df81175c
Author: Ronald G. Minnich <rminnich at google.com>
Date:   Wed Jul 10 17:27:45 2013 -0700

    Pit: set PWM to external on Parade
    
    The PWM is controlled externally from the APU.
    
    Change-Id: Ia5130d7616991a78dfde44043a60a32cee4f145c
    Signed-off-by: Ronald G. Minnich <rminnich at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/61513
    Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Commit-Queue: Ronald G. Minnich <rminnich at chromium.org>
    Tested-by: Ronald G. Minnich <rminnich at chromium.org>
---
 src/mainboard/google/pit/mainboard.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/mainboard/google/pit/mainboard.c b/src/mainboard/google/pit/mainboard.c
index 515424a..3f04eec 100644
--- a/src/mainboard/google/pit/mainboard.c
+++ b/src/mainboard/google/pit/mainboard.c
@@ -146,13 +146,8 @@ static const struct parade_write parade_writes[] = {
 	{ 0x01, 0xca, 0x01 },
 	 /* DPCD40B, Initial Code minor revision '05' */
 	{ 0x01, 0xcb, 0x05 },
-	 /* DPCD720, Select internal PWM */
-	{ 0x01, 0xa5, 0xa0 },
-	 /*
-	  * FFh for 100% PWM of brightness, 0h for 0%
-	  * brightness
-	  */
-	{ 0x01, 0xa7, 0xff },
+	 /* DPCD720, Select external PWM */
+	{ 0x01, 0xa5, 0x80 },
 	 /*
 	  * Set LVDS output as 6bit-VESA mapping,
 	  * single LVDS channel



More information about the coreboot-gerrit mailing list