[coreboot-gerrit] New patch to review for coreboot: 2acdb13 Revert "Northbridge: i945: Native VGA init: use UMA address"
Alexandru Gagniuc (mr.nuke.me@gmail.com)
gerrit at coreboot.org
Tue Dec 17 23:21:29 CET 2013
Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4539
-gerrit
commit 2acdb13b33f65ac4652264d5ab5886617ee403c5
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date: Tue Dec 17 16:19:13 2013 -0600
Revert "Northbridge: i945: Native VGA init: use UMA address"
This reverts commit 03e4ac6671e91a0180f6eec3db9f55a7c2adbba1.
The native VGA code was unfinished and submitted in error. Revert it
in anticipation of the finished patches.
Change-Id: Iffbd99c3b583b39724079d6cc4675b752d9e08f6
Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
src/northbridge/intel/i945/gma.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index 433152c..e9ae715 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -52,9 +52,10 @@ static void gma_func0_init(struct device *dev)
#if CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT
/* This should probably run before post VBIOS init. */
printk(BIOS_SPEW, "Initializing VGA without OPROM.\n");
- u32 iobase, mmiobase, graphics_base;
+ u32 iobase, mmiobase, physbase, graphics_base;
iobase = dev->resource_list[1].base;
mmiobase = dev->resource_list[0].base;
+ physbase = pci_read_config32(dev, 0x5c) & ~0xf;
graphics_base = dev->resource_list[2].base + 0x20000;
printk(BIOS_SPEW, "GMADR=0x%08x GTTADR=0x%08x\n",
@@ -63,7 +64,7 @@ static void gma_func0_init(struct device *dev)
);
int i915lightup(u32 physbase, u32 iobase, u32 mmiobase, u32 gfx);
- i915lightup(uma_memory_base, iobase, mmiobase, graphics_base);
+ i915lightup(physbase, iobase, mmiobase, graphics_base);
#endif
}
More information about the coreboot-gerrit
mailing list