[coreboot-gerrit] Patch set updated for coreboot: e23779b lynxpoint: me: Disable some verbose messages

[Patrick Georgi (patrick@georgi-clan.de)]

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4452

-gerrit

commit e23779baed661998430707ca95e3bc1f17bb9280
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Thu Aug 8 15:40:01 2013 -0700

    lynxpoint: me: Disable some verbose messages
    
    The default ME output is quite verbose and not all that useful
    unless you are actively debugging the ME and then you can enable
    the CONFIG_DEBUG_INTEL_ME option.
    
    This commit silences the firmware capabilities and the MBP output.
    
    Change-Id: I2b8abcb34ae0d00d9a38d029979e84ee0d0ca287
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/65252
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/southbridge/intel/lynxpoint/me_9.x.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/southbridge/intel/lynxpoint/me_9.x.c b/src/southbridge/intel/lynxpoint/me_9.x.c
index e01316f..d3dfcfb 100644
--- a/src/southbridge/intel/lynxpoint/me_9.x.c
+++ b/src/southbridge/intel/lynxpoint/me_9.x.c
@@ -496,6 +496,7 @@ static void me_print_fw_version(mbp_fw_version_name *vers_name)
 	       vers_name->hotfix_version, vers_name->build_version);
 }
 
+#if CONFIG_DEBUG_INTEL_ME
 /* Get ME Firmware Capabilities */
 static int mkhi_get_fwcaps(mbp_mefwcaps *cap)
 {
@@ -543,6 +544,7 @@ static void me_print_fwcaps(mbp_mefwcaps *cap)
 	print_cap("Wireless LAN (WLAN)", cap->wlan);
 }
 #endif
+#endif
 
 #if CONFIG_CHROMEOS && 0 /* DISABLED */
 /* Tell ME to issue a global reset */
@@ -836,7 +838,9 @@ static void intel_me_init(device_t dev)
 
 #if (CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_DEBUG)
 	me_print_fw_version(mbp_data.fw_version_name);
+#if CONFIG_DEBUG_INTEL_ME
 	me_print_fwcaps(mbp_data.fw_capabilities);
+#endif
 
 	if (mbp_data.plat_time) {
 		printk(BIOS_DEBUG, "ME: Wake Event to ME Reset:      %u ms\n",
@@ -1001,10 +1005,12 @@ static int intel_me_read_mbp(me_bios_payload *mbp_data, device_t dev)
 #if (CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_DEBUG)
 	printk(BIOS_INFO, "ME MBP: Header: items: %d, size dw: %d\n",
 	       mbp->header.num_entries, mbp->header.mbp_size);
+#if CONFIG_DEBUG_INTEL_ME
 	for (i = 0; i < mbp->header.mbp_size - 1; i++) {
 		printk(BIOS_INFO, "ME MBP: %04x: 0x%08x\n", i, mbp->data[i]);
 	}
 #endif
+#endif
 
 	#define ASSIGN_FIELD_PTR(field_,val_) \
 		{ \
@@ -1047,8 +1053,8 @@ static int intel_me_read_mbp(me_bios_payload *mbp_data, device_t dev)
 			ASSIGN_FIELD_PTR(nfc_data, &mbp->data[i+1]);
 
 		default:
-			printk(BIOS_ERR, "ME MBP: unknown item 0x%x @ dw offset 0x%x\n",
-			       mbp->data[i], i);
+			printk(BIOS_ERR, "ME MBP: unknown item 0x%x @ "
+			       "dw offset 0x%x\n", mbp->data[i], i);
 			break;
 		}
 		i += item->length;