[coreboot-gerrit] Patch set updated for coreboot: e23689f exynos5420: Apply pwm const fix to the 5420 as well

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Dec 21 09:15:17 CET 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4417

-gerrit

commit e23689f1263ffe08e69fcdd896f500128c5fee9d
Author: Gabe Black <gabeblack at google.com>
Date:   Wed Jul 31 22:13:24 2013 -0700

    exynos5420: Apply pwm const fix to the 5420 as well
    
    When the const was removed from write function arguments, a related bug in the
    5250 code was fixed so that it would still compile. Unfortunately, that same
    change needed to be made to the 5420.
    
    Change-Id: If15057c92422de91dc8e35dbd8b5c978bfae122a
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/64154
    Reviewed-by: Ronald G. Minnich <rminnich at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
---
 src/cpu/samsung/exynos5420/pwm.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/cpu/samsung/exynos5420/pwm.c b/src/cpu/samsung/exynos5420/pwm.c
index 34fc2b1..7375f1b 100644
--- a/src/cpu/samsung/exynos5420/pwm.c
+++ b/src/cpu/samsung/exynos5420/pwm.c
@@ -25,8 +25,7 @@
 
 int pwm_enable(int pwm_id)
 {
-	const struct s5p_timer *pwm =
-			samsung_get_base_timer();
+	struct s5p_timer *const pwm = samsung_get_base_timer();
 	unsigned long tcon;
 
 	tcon = readl(&pwm->tcon);
@@ -39,8 +38,7 @@ int pwm_enable(int pwm_id)
 
 int pwm_check_enabled(int pwm_id)
 {
-	const struct s5p_timer *pwm =
-			samsung_get_base_timer();
+	const struct s5p_timer *const pwm = samsung_get_base_timer();
 	const unsigned long tcon = readl(&pwm->tcon);
 
 	return tcon & TCON_START(pwm_id);
@@ -48,8 +46,7 @@ int pwm_check_enabled(int pwm_id)
 
 void pwm_disable(int pwm_id)
 {
-	const struct s5p_timer *pwm =
-			samsung_get_base_timer();
+	struct s5p_timer *const pwm = samsung_get_base_timer();
 	unsigned long tcon;
 
 	tcon = readl(&pwm->tcon);
@@ -77,8 +74,7 @@ static unsigned long pwm_calc_tin(int pwm_id, unsigned long freq)
 
 int pwm_config(int pwm_id, int duty_ns, int period_ns)
 {
-	const struct s5p_timer *pwm =
-			samsung_get_base_timer();
+	struct s5p_timer *const pwm = samsung_get_base_timer();
 	unsigned int offset;
 	unsigned long tin_rate;
 	unsigned long tin_ns;
@@ -134,8 +130,7 @@ int pwm_config(int pwm_id, int duty_ns, int period_ns)
 int pwm_init(int pwm_id, int div, int invert)
 {
 	u32 val;
-	const struct s5p_timer *pwm =
-			samsung_get_base_timer();
+	struct s5p_timer *const pwm = samsung_get_base_timer();
 	unsigned long ticks_per_period;
 	unsigned int offset, prescaler;
 



More information about the coreboot-gerrit mailing list