[coreboot-gerrit] Patch set updated for coreboot: f38d0d4 exynos5250: Fix consts in the pwm code

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Dec 21 10:00:52 CET 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4397

-gerrit

commit f38d0d4f39147dab8f764170fc9d9cb7aa3d2f7b
Author: Gabe Black <gabeblack at google.com>
Date:   Tue Jul 30 13:38:13 2013 -0700

    exynos5250: Fix consts in the pwm code
    
    The code generally intended to make the pointer const instead of the thing it
    pointed at, but it had const backwards. Sometimes both the pointer and the
    data could be const, but sometimes there were writes where only the pointer
    should be.
    
    Change-Id: Ifcd5495769b86b47d7b583cce63ed5c2158bec4e
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/63775
    Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
---
 src/cpu/samsung/exynos5250/pwm.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/cpu/samsung/exynos5250/pwm.c b/src/cpu/samsung/exynos5250/pwm.c
index 34fc2b1..eeb6721 100644
--- a/src/cpu/samsung/exynos5250/pwm.c
+++ b/src/cpu/samsung/exynos5250/pwm.c
@@ -25,8 +25,7 @@
 
 int pwm_enable(int pwm_id)
 {
-	const struct s5p_timer *pwm =
-			samsung_get_base_timer();
+	struct s5p_timer *const pwm = samsung_get_base_timer();
 	unsigned long tcon;
 
 	tcon = readl(&pwm->tcon);
@@ -39,8 +38,7 @@ int pwm_enable(int pwm_id)
 
 int pwm_check_enabled(int pwm_id)
 {
-	const struct s5p_timer *pwm =
-			samsung_get_base_timer();
+	const struct s5p_timer *pwm = samsung_get_base_timer();
 	const unsigned long tcon = readl(&pwm->tcon);
 
 	return tcon & TCON_START(pwm_id);
@@ -48,8 +46,7 @@ int pwm_check_enabled(int pwm_id)
 
 void pwm_disable(int pwm_id)
 {
-	const struct s5p_timer *pwm =
-			samsung_get_base_timer();
+	struct s5p_timer *const pwm = samsung_get_base_timer();
 	unsigned long tcon;
 
 	tcon = readl(&pwm->tcon);
@@ -77,8 +74,7 @@ static unsigned long pwm_calc_tin(int pwm_id, unsigned long freq)
 
 int pwm_config(int pwm_id, int duty_ns, int period_ns)
 {
-	const struct s5p_timer *pwm =
-			samsung_get_base_timer();
+	struct s5p_timer *const pwm = samsung_get_base_timer();
 	unsigned int offset;
 	unsigned long tin_rate;
 	unsigned long tin_ns;
@@ -134,8 +130,7 @@ int pwm_config(int pwm_id, int duty_ns, int period_ns)
 int pwm_init(int pwm_id, int div, int invert)
 {
 	u32 val;
-	const struct s5p_timer *pwm =
-			samsung_get_base_timer();
+	struct s5p_timer *const pwm = samsung_get_base_timer();
 	unsigned long ticks_per_period;
 	unsigned int offset, prescaler;
 



More information about the coreboot-gerrit mailing list