[coreboot-gerrit] New patch to review for coreboot: 3384323 lib/hexdump.c: Indent with tabs instead of spaces and remove empty lines
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Fri Dec 27 14:48:20 CET 2013
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4576
-gerrit
commit 3384323156bd9cae0b1828630102f715705ccbcd
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Fri Dec 27 14:43:44 2013 +0100
lib/hexdump.c: Indent with tabs instead of spaces and remove empty lines
The coding style requires to use tabs for indentation and not spaces.
$ indent --version
GNU indent: 2.2.11
$ indent -linux src/lib/hexdump.c
This also removes the empty lines at the end of the file.
Change-Id: I874f178e50d7558d3299026aec2771ad45f88d8e
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
src/lib/hexdump.c | 64 +++++++++++++++++++++++++++----------------------------
1 file changed, 31 insertions(+), 33 deletions(-)
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c
index 20babe4..98d356f 100644
--- a/src/lib/hexdump.c
+++ b/src/lib/hexdump.c
@@ -28,38 +28,36 @@ static int isprint(int c)
return (c >= 32 && c <= 126);
}
-void hexdump(void* memory, size_t length)
+void hexdump(void *memory, size_t length)
{
- int i;
- uint8_t *m;
- int all_zero = 0;
-
- m = (uint8_t *)memory;
-
- for (i = 0; i < length; i += 16) {
- int j;
-
- all_zero++;
- for (j = 0; j < 16; j++) {
- if(m[i+j] != 0) {
- all_zero = 0;
- break;
- }
- }
-
- if (all_zero < 2) {
- printk(BIOS_DEBUG, "%p:", memory + i);
- for (j = 0; j < 16; j++)
- printk(BIOS_DEBUG, " %02x", m[i+j]);
- printk(BIOS_DEBUG, " ");
- for (j = 0; j < 16; j++)
- printk(BIOS_DEBUG, "%c",
- isprint(m[i+j]) ? m[i+j] : '.');
- printk(BIOS_DEBUG, "\n");
- } else if (all_zero == 2) {
- printk(BIOS_DEBUG, "...\n");
- }
- }
+ int i;
+ uint8_t *m;
+ int all_zero = 0;
+
+ m = (uint8_t *) memory;
+
+ for (i = 0; i < length; i += 16) {
+ int j;
+
+ all_zero++;
+ for (j = 0; j < 16; j++) {
+ if (m[i + j] != 0) {
+ all_zero = 0;
+ break;
+ }
+ }
+
+ if (all_zero < 2) {
+ printk(BIOS_DEBUG, "%p:", memory + i);
+ for (j = 0; j < 16; j++)
+ printk(BIOS_DEBUG, " %02x", m[i + j]);
+ printk(BIOS_DEBUG, " ");
+ for (j = 0; j < 16; j++)
+ printk(BIOS_DEBUG, "%c",
+ isprint(m[i + j]) ? m[i + j] : '.');
+ printk(BIOS_DEBUG, "\n");
+ } else if (all_zero == 2) {
+ printk(BIOS_DEBUG, "...\n");
+ }
+ }
}
-
-
More information about the coreboot-gerrit
mailing list