[coreboot-gerrit] Patch set updated for coreboot: 0b5fd8c superio: Uncomment the w83627uhg UART clock source initialization
Dave Frodin (dave.frodin@se-eng.com)
gerrit at coreboot.org
Sun Dec 29 18:16:08 CET 2013
Dave Frodin (dave.frodin at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4573
-gerrit
commit 0b5fd8c88e71f2e1ac37a163686446f225cc7306
Author: Dave Frodin <dave.frodin at se-eng.com>
Date: Thu Dec 26 08:17:16 2013 -0700
superio: Uncomment the w83627uhg UART clock source initialization
The asrock/imb-a180 mainboard is evidently the first mainboard to
use this superio. The imb-a180 actually uses a Nuvoton NCT6627UD
which is the same as the w83627uhg. The default h/w clock setting
is 0. When I added the SIO in the mainboard Kconfig and the SIO
code got built, the builder complained that the set_uart_clock_source() wasn't being used. So I uncommented the calls to that function.
Change-Id: Iedba035237c5c0fa230b02ff4799bb8c1b7bbd4a
Signed-off-by: Dave Frodin <dave.frodin at se-eng.com>
---
src/superio/winbond/w83627uhg/superio.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/superio/winbond/w83627uhg/superio.c b/src/superio/winbond/w83627uhg/superio.c
index 3f1ca38..9de7ac0 100644
--- a/src/superio/winbond/w83627uhg/superio.c
+++ b/src/superio/winbond/w83627uhg/superio.c
@@ -68,22 +68,22 @@ static void w83627uhg_init(device_t dev)
switch(dev->path.pnp.device) {
case W83627UHG_SP1:
- /* set_uart_clock_source(dev, 0); */
+ set_uart_clock_source(dev, 0);
break;
case W83627UHG_SP2:
- /* set_uart_clock_source(dev, 0); */
+ set_uart_clock_source(dev, 0);
break;
case W83627UHG_SP3:
- /* set_uart_clock_source(dev, 0); */
+ set_uart_clock_source(dev, 0);
break;
case W83627UHG_SP4:
- /* set_uart_clock_source(dev, 0); */
+ set_uart_clock_source(dev, 0);
break;
case W83627UHG_SP5:
- /* set_uart_clock_source(dev, 0); */
+ set_uart_clock_source(dev, 0);
break;
case W83627UHG_SP6:
- /* set_uart_clock_source(dev, 0); */
+ set_uart_clock_source(dev, 0);
break;
case W83627UHG_KBC:
pc_keyboard_init(&conf->keyboard);
More information about the coreboot-gerrit
mailing list