[coreboot-gerrit] Patch merged into coreboot/master: e978fc2 cbmem: Fix makefile

gerrit at coreboot.org gerrit at coreboot.org
Mon Jul 1 23:12:23 CEST 2013


the following patch was just integrated into master:
commit e978fc265d22d54146ba167b63ed0e3a6d4875a5
Author: Stefan Tauner <stefan.tauner at gmx.at>
Date:   Sun Jun 30 01:05:30 2013 +0200

    cbmem: Fix makefile
    
    The .dependencies rule did not use the CPPFLAGS variable which led
    to funny behavior: a spurious termination message the first time
    (after checkout/make distclean) one executes make. Afterwards the
    (wrongly) empty .dependencies file hides the problem and the binary
    is created anyway.
    
    $ make
    cbmem.c:37:34: fatal error: boot/coreboot_tables.h: No such file or directory
    compilation terminated.
    cc -O2 -Wall -Werror -iquote ../../src/include -iquote ../../src/src/arch/x86  -c -o cbmem.o cbmem.c
    cc   cbmem.o   -o cbmem
    
    $ make
    make: Nothing to be done for `all'.
    
    $ make clean
    rm -f cbmem *.o *~
    
    $ make
    cc -O2 -Wall -Werror -iquote ../../src/include -iquote ../../src/src/arch/x86  -c -o cbmem.o cbmem.c
    cc   cbmem.o   -o cbmem
    
    $ make distclean
    rm -f cbmem *.o *~
    rm -f .dependencies
    
    $ make
    cbmem.c:37:34: fatal error: boot/coreboot_tables.h: No such file or directory
    compilation terminated.
    cc -O2 -Wall -Werror -iquote ../../src/include -iquote ../../src/src/arch/x86  -c -o cbmem.o cbmem.c
    cc   cbmem.o   -o cbmem
    
    I fixed that by adding the CPPFLAGS variable to the .dependencies recipe, just
    like Stefan Reinauer did in Chromium (Ia9d2e10a3ef122f30d681d16c2291eb108ead835),
    hence the split sign-off for this tiny change. :)
    
    Change-Id: Icd11b146ad762cbdf9774630b950f70e1253a072
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
    Signed-off-by: Stefan Tauner <stefan.tauner at gmx.at>
    Reviewed-on: http://review.coreboot.org/3548
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Nico Huber <nico.huber at secunet.com>


See http://review.coreboot.org/3548 for details.

-gerrit



More information about the coreboot-gerrit mailing list