[coreboot-gerrit] New patch to review for coreboot: e00f621 google/pit: Don't spew output with GPIO config

Gabe Black (gabeblack@chromium.org) gerrit at coreboot.org
Tue Jul 9 05:29:15 CEST 2013


Gabe Black (gabeblack at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3670

-gerrit

commit e00f6216e893753ee2bd42760784d69af8ee8093
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Mon May 20 12:51:02 2013 -0700

    google/pit: Don't spew output with GPIO config
    
    There are hundreds of GPIOs on the Exynos5420. Don't
    always print all of them per default.
    
    Change-Id: I2152ab760e31a335dbcd9d6ad32cd1eaae4b89bc
    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
---
 src/mainboard/google/pit/mainboard.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/pit/mainboard.c b/src/mainboard/google/pit/mainboard.c
index 77d48f9..dccb095 100644
--- a/src/mainboard/google/pit/mainboard.c
+++ b/src/mainboard/google/pit/mainboard.c
@@ -201,6 +201,8 @@ static void mainboard_init(device_t dev)
 	set_vbe_mode_info_valid(&edid, (uintptr_t)fb_addr);
 
 	lcd_vdd();
+
+	// FIXME: should timeout
 	do {
 		udelay(50);
 	} while (!exynos_dp_hotplug());
@@ -228,7 +230,8 @@ static void mainboard_init(device_t dev)
 	if (dp_tries > MAX_DP_TRIES)
 		printk(BIOS_ERR, "%s: Failed to set up displayport\n", __func__);
 
-	gpio_info();
+	// Uncomment to get excessive GPIO output:
+	// gpio_info();
 }
 
 static void mainboard_enable(device_t dev)



More information about the coreboot-gerrit mailing list