[coreboot-gerrit] Patch merged into coreboot/master: b2893a0 Provide support for setting up the framebuffer from EDID
gerrit at coreboot.org
gerrit at coreboot.org
Wed Jul 10 02:39:29 CEST 2013
the following patch was just integrated into master:
commit b2893a0169ce603926bf13465432a15c4526de97
Author: Ronald G. Minnich <rminnich at google.com>
Date: Tue Apr 23 10:59:11 2013 -0700
Provide support for setting up the framebuffer from EDID
Add three functions to edid.c:
void set_vbe_mode_info_valid(struct edid *edid, uintptr_t fb_addr)
takes an edid and uintptr_t, and fills in a static lb_framebuffer struct
as well as setting the static vbe_valid to 1 unless some problem
is found in the edid. The intent here is that this could be called from
the native graphics setup code on both ARM and x86.
int vbe_mode_info_valid(void)
returns value of the static vbe_valid.
void fill_lb_framebuffer(struct lb_framebuffer *framebuffer)
copies the static edid_fb to lb_framebuffer.
There is now a common vbe.h in src/include, removed the two special ones.
In general, graphics in coreboot is a mess, but graphics is always a
mess. We don't have a clean way to try two different ways to turn on
a device and use the one that works. One battle at a time. Overall,
things are much better.
The best part: this code would also work for ARM, which also uses EDID.
Change-Id: Id23eb61498b331d44ab064b8fb4cb10f07cff7f3
Signed-off-by: Ronald G. Minnich <rminnich at google.com>
Signed-off-by: Gabe Black <gabeblack at chromium.org>
Reviewed-on: http://review.coreboot.org/3636
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
See http://review.coreboot.org/3636 for details.
-gerrit
More information about the coreboot-gerrit
mailing list