[coreboot-gerrit] Patch merged into coreboot/master: 29a4355 Provide sane Kconfig default for cmos.default.

gerrit at coreboot.org gerrit at coreboot.org
Sun Jun 2 23:07:23 CEST 2013

the following patch was just integrated into master:
commit 29a435597345e1e05a449f2e864c8e3746538c45
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date:   Tue May 28 13:46:12 2013 +0200

    Provide sane Kconfig default for cmos.default.
    Without that fix we have with CONFIG_USE_OPTION_TABLE:
        OPTION     cmos_layout.bin
      build/util/nvramtool/nvramtool -y /home/gnutoo/x86/coreboot-alix/src/mainboard/pcengines/alix1c/cmos.layout -L build/cmos_layout.bin
      make: *** No rule to make target `nvramtool', needed by `build/coreboot.pre1'.  Stop.
      rm build/util/sconfig/sconfig.tab.c build/cbfs/fallback/bootblock.elf build/util/sconfig/lex.yy.c
    That log was captured with make V=1 but the error also appear with make.
    Tested on the PC Engines ALIX.1C with the following commit (Change-Id: Ia87b090) [1]:
      PC Engines ALIX.1C: Add CMOS defaults.
    [1] http://review.coreboot.org/#/c/3323/
    Change-Id: I548005a58f430ed7b6da5249a24bbdcae440a1e9
    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
    Reviewed-on: http://review.coreboot.org/3223
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
    Tested-by: build bot (Jenkins)

See http://review.coreboot.org/3223 for details.


More information about the coreboot-gerrit mailing list