[coreboot-gerrit] Patch merged into coreboot/master: 42409e8 northbridge/amd/amdmct: Use `static const` instead of `const static`

gerrit at coreboot.org gerrit at coreboot.org
Mon Jun 3 08:20:55 CEST 2013

the following patch was just integrated into master:
commit 42409e87322e974e81db9e0ac8b454e205fe8d3b
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat May 4 18:07:13 2013 +0200

    northbridge/amd/amdmct: Use `static const` instead of `const static`
    From ISO C99 standard: »The placement of a storage-class specifier
    other than at the beginning of the declaration specifiers in a
    declaration is an obsolescent feature.«
    Found at <http://www.approxion.com/?p=41>.
    The following command was used to make the change.
        $ git grep -l 'const static' src/ | xargs sed -i 's/const static/static const/'
    As asked by Bruce Griffith, the changes in `src/vendorcode` were
    reverted as that is what AMD prefers.
    The same change was done already for AMD Persimmon in the following
        commit 824e192809e021b3cdee947a44b3a18d276bdb35
        Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
        Date:   Wed Feb 20 21:24:20 2013 +0100
            Persimmon: platform_cfg.h: Declare codec arrays as `static const`
            Reviewed-on: http://review.coreboot.org/2474
    Change-Id: I233c83fdc95ea4f83f7296c818547beb52366a3d
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/3197
    Tested-by: build bot (Jenkins)
    Reviewed-by: Bruce Griffith <Bruce.Griffith at se-eng.com>
    Reviewed-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>

See http://review.coreboot.org/3197 for details.


More information about the coreboot-gerrit mailing list