[coreboot-gerrit] New patch to review for coreboot: b5cf3d3 (Trivial) early_smbus: fix printsmbus macro

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Thu Jun 6 03:59:31 CEST 2013

Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3379


commit b5cf3d351a46a958e4ec60cd745415e0c2212bcb
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Jun 5 20:01:42 2013 -0500

    (Trivial) early_smbus: fix printsmbus macro
    When I've first written this macro in 2011, the correct define for
    verbose SMBus message was CONFIG_DEBUG_SMBUS_SETUP. This has since
    been changed to CONFIG_DEBUG_SMBUS. I didn't catch that, and this made
    the printsmbus macro always evaluate to an empty statement.
    Use the proper CONFIG_DEBUG_SMBUS define. This makes printsmbus
    functional again.
    Change-Id: Iaf03354b179cc4a061e0b65f5b746af10f5d2b88
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
 src/include/device/early_smbus.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/include/device/early_smbus.h b/src/include/device/early_smbus.h
index 77c9078..5e15bb1 100644
--- a/src/include/device/early_smbus.h
+++ b/src/include/device/early_smbus.h
@@ -55,7 +55,7 @@
  * \brief printk macro for SMBus debugging
 #define printsmbus(x, ...) printk(BIOS_DEBUG, x, ##__VA_ARGS__)
 #define printsmbus(x, ...)

More information about the coreboot-gerrit mailing list