[coreboot-gerrit] New patch to review for coreboot: 65c6932 buildgcc: Re-add some break statements

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sun Jun 9 08:09:07 CEST 2013

Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3418


commit 65c6932c448279046d0b141c51902fbb33babf4c
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sun Jun 9 08:05:45 2013 +0200

    buildgcc: Re-add some break statements
    While some of the case .. break statement actually weren't needed,
    too are, since otherwise the option parsing loop hangs.
    Exit conditions for that endless loop: "--" or no more arguments,
    in line with GNU command line parsing rules.
    Change-Id: I0dbc35e530fb8c93a0f7de05ac47f325555ad4a4
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
 util/crossgcc/buildgcc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 1d8e54c..4458ea4 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -215,9 +215,9 @@ while true ; do
 		-G|--gdb)	shift; SKIPGDB=0;;
 		-S|--scripting) shift; SKIPPYTHON=0;;
 		-y|--ccache)	shift; USECCACHE=1;;
-		--)		shift;;
+		--)		shift; break;;
 		-*)		printf "Invalid option\n\n"; myhelp; exit 1;;
-		*)		;;
+		*)		break;;

More information about the coreboot-gerrit mailing list