[coreboot-gerrit] New patch to review for coreboot: 51ffd01 intel/bd82x6x/Makefile.inc: Remove duplicate inclusions of `usb_debug.c`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Mon Jun 10 10:58:48 CEST 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3425


commit 51ffd015dc14b19d63d9fd20562a454c1cce0141
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Jun 10 10:49:31 2013 +0200

    intel/bd82x6x/Makefile.inc: Remove duplicate inclusions of `usb_debug.c`
    Currently the Makefile.inc includes `usb_debug.c` several times.
    This was introduced in
        commit 4063ede3fb571110c3e65c321049cc2687cc54fa
        Author: Ronald G. Minnich <rminnich at google.com>
        Date:   Mon Feb 4 20:31:51 2013 -0800
            bd82x6x: Fix compiling with USB debug port support
            Reviewed-on: http://review.coreboot.org/2784
    but was unneeded because it was already added in the following
        commit 4141993536039e0d45caeacb745a89d388f0724b
        Author: Sven Schnelle <svens at stackframe.org>
        Date:   Sat Jul 28 08:52:44 2012 +0200
            bd82x6x: Fix CONFIG_USBDEBUG
            Reviewed-on: http://review.coreboot.org/1376
    Therefore basically revert that hunk.
    Change-Id: Iaa8de6fcc0d6f3a0a92a28fcb603d7777aa8b24c
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/southbridge/intel/bd82x6x/Makefile.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/southbridge/intel/bd82x6x/Makefile.inc b/src/southbridge/intel/bd82x6x/Makefile.inc
index f833ba1..0081a7d 100644
--- a/src/southbridge/intel/bd82x6x/Makefile.inc
+++ b/src/southbridge/intel/bd82x6x/Makefile.inc
@@ -49,8 +49,6 @@ smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c me.c me_8.x.c finalize.c pch.c
 romstage-y += early_usb.c early_smbus.c early_me.c me_status.c gpio.c
 romstage-$(CONFIG_USBDEBUG) += usb_debug.c
-ramstage-$(CONFIG_USBDEBUG) += usb_debug.c
-smm-$(CONFIG_USBDEBUG) += usb_debug.c
 romstage-y += reset.c
 romstage-y += early_spi.c

More information about the coreboot-gerrit mailing list