[coreboot-gerrit] Patch set updated for coreboot: fe190d2 intel/bd82x6x/Makefile.inc: Revert duplicate addition of `usb_debug.c`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Tue Jun 11 10:00:56 CEST 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3425


commit fe190d23c539057b8f7f7c5f607e8d6fda042d08
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Mon Jun 10 10:49:31 2013 +0200

    intel/bd82x6x/Makefile.inc: Revert duplicate addition of `usb_debug.c`
    Currently in Intel BD82x6x southbridge’s `Makefile.inc` the
    file `usb_debug.c` is added twice to the build.
    This was introduced in
        commit 4063ede3fb571110c3e65c321049cc2687cc54fa
        Author: Ronald G. Minnich <rminnich at google.com>
        Date:   Mon Feb 4 20:31:51 2013 -0800
            bd82x6x: Fix compiling with USB debug port support
            Reviewed-on: http://review.coreboot.org/2784
    but was unneeded because it had been already added in
    the following commit.
        commit 4141993536039e0d45caeacb745a89d388f0724b
        Author: Sven Schnelle <svens at stackframe.org>
        Date:   Sat Jul 28 08:52:44 2012 +0200
            bd82x6x: Fix CONFIG_USBDEBUG
            Reviewed-on: http://review.coreboot.org/1376
    Therefore basically revert that hunk.
    There is no policy on how to order these additions, so leave
    it to a possible separate commit, unifying this.
    Kyösti Mälkki suspects that these additions were meant for
    the Intel Lynx Point [1].
    [1] http://review.coreboot.org/#/c/3424/
    Change-Id: Iaa8de6fcc0d6f3a0a92a28fcb603d7777aa8b24c
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/southbridge/intel/bd82x6x/Makefile.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/southbridge/intel/bd82x6x/Makefile.inc b/src/southbridge/intel/bd82x6x/Makefile.inc
index f833ba1..2e10e03 100644
--- a/src/southbridge/intel/bd82x6x/Makefile.inc
+++ b/src/southbridge/intel/bd82x6x/Makefile.inc
@@ -40,9 +40,7 @@ ramstage-y += watchdog.c
 ramstage-$(CONFIG_ELOG) += elog.c
 ramstage-y += spi.c
-ramstage-$(CONFIG_USBDEBUG) += usb_debug.c
 smm-$(CONFIG_SPI_FLASH_SMM) += spi.c
-smm-$(CONFIG_USBDEBUG) += usb_debug.c
 ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c
 smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c me.c me_8.x.c finalize.c pch.c

More information about the coreboot-gerrit mailing list