[coreboot-gerrit] Patch merged into coreboot/master: a146d58 ramstage: prepare for relocation

gerrit at coreboot.org gerrit at coreboot.org
Thu Mar 21 18:01:42 CET 2013

the following patch was just integrated into master:
commit a146d58ca0375a12f23dc5a4bd25adfa3423114f
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Feb 8 16:56:51 2013 -0600

    ramstage: prepare for relocation
    The current ramstage code contains uses of symbols that cause issues
    when the ramstage is relocatable. There are 2 scenarios resolved by this
    1. Absolute symbols that are actually sizes/limits. The symbols are
       problematic when relocating a program because there is no way to
       distinguish a symbol that shouldn't be relocated and one that can.
       The only way to handle these symbols is to write a program to post
       process the relocations and keep a whitelist of ones that shouldn't
       be relocated. I don't believe that is a route that should be taken
       so fix the users of these sizes/limits encoded as absolute symbols
       to calculate the size at runtime or dereference a variable in memory
       containing the size/limit.
    2. Absoulte symbols that were relocated to a fixed address. These
       absolute symbols are generated by assembly files to be placed at a
       fixed location. Again, these symbols are problematic because one
       can't distinguish a symbol that can't be relocated. The symbols
       are again resolved at runtime to allow for proper relocation.
    For the symbols defining a size either use 2 symbols and calculate the
    difference or provide a variable in memory containing the size.
    Change-Id: I1ef2bfe6fd531308218bcaac5dcccabf8edf932c
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/2789
    Tested-by: build bot (Jenkins)
    Reviewed-by: Marc Jones <marc.jones at se-eng.com>

Build-Tested: build bot (Jenkins) at Tue Mar 19 03:57:16 2013, giving +1
See http://review.coreboot.org/2789 for details.


More information about the coreboot-gerrit mailing list