[coreboot-gerrit] New patch to review for coreboot: 6275503 Fix race condition building console code

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu Mar 21 21:18:43 CET 2013


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2873

-gerrit

commit 6275503a7f43e697ccd6970fc8afa5ba83c3ecc2
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Thu Mar 21 13:15:45 2013 -0700

    Fix race condition building console code
    
    On ARMv7 the console code can also be built into
    the bootblock. Currently building the ARM targets
    on a reasonably fast machine can fail, because
    console.bootblock.o is attempted to build before
    build.h is created. This patch adds a specific
    rule for the bootblock variant of console.c, to
    match the other variants so that the race condition
    goes away.
    
    Change-Id: I52e4242c66a02f011ef26b854aa50c2606a1f81f
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/console/Makefile.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/console/Makefile.inc b/src/console/Makefile.inc
index 9499180..40bf357 100644
--- a/src/console/Makefile.inc
+++ b/src/console/Makefile.inc
@@ -28,3 +28,4 @@ ramstage-$(CONFIG_CONSOLE_CBMEM) += cbmem_console.c
 
 $(obj)/console/console.ramstage.o : $(obj)/build.h
 $(obj)/console/console.romstage.o : $(obj)/build.h
+$(obj)/console/console.bootblock.o : $(obj)/build.h



More information about the coreboot-gerrit mailing list