[coreboot-gerrit] Patch merged into coreboot/master: 57686f8 x86: unify amd and non-amd MTRR routines
gerrit at coreboot.org
gerrit at coreboot.org
Fri Mar 22 04:06:43 CET 2013
the following patch was just integrated into master:
commit 57686f848597f6b133c9d45a9b98a54638399b32
Author: Aaron Durbin <adurbin at chromium.org>
Date: Wed Mar 20 15:50:59 2013 -0500
x86: unify amd and non-amd MTRR routines
The amd_mtrr.c file contains a copy of the fixed MTRR algorithm.
However, the AMD code needs to handle the RdMem and WrMem attribute
bits in the fixed MTRR MSRs. Instead of duplicating the code
with the one slight change introduce a Kconfig option,
X86_AMD_FIXED_MTRRS, which indicates that the RdMem and WrMem fields
need to be handled for writeback fixed MTRR ranges.
The order of how the AMD MTRR setup routine is maintained by providing
a x86_setup_fixed_mtrrs_no_enable() function which does not enable
the fixed MTRRs after setting them up. All Kconfig files which had a
Makefile that included amd/mtrr in the subdirs-y now have a default
X86_AMD_FIXED_MTRRS selection. There may be some overlap with the
agesa and socket code, but I didn't know the best way to tease out
the interdependency.
Change-Id: I256d0210d1eb3004e2043b46374dcc0337432767
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-on: http://review.coreboot.org/2866
Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
Tested-by: build bot (Jenkins)
Build-Tested: build bot (Jenkins) at Fri Mar 22 04:04:23 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Fri Mar 22 03:38:09 2013, giving +2
See http://review.coreboot.org/2866 for details.
-gerrit
More information about the coreboot-gerrit
mailing list