[coreboot-gerrit] New patch to review for coreboot: 60e2f7d libpayload: Fix unused function warning in EHCI stack

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Mon Mar 25 23:57:26 CET 2013

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2909


commit 60e2f7d8e517eb1a3553754ba99434e287d271fa
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Mon Mar 25 15:56:08 2013 -0700

    libpayload: Fix unused function warning in EHCI stack
    The function dump_qh() was added a while back but never used.
    Hide it behind USB_DEBUG so it doesn't cause warnings when not
    debugging the USB stack.
    Change-Id: Idb3c7bb214895ef82676d181836a578bf161e8e0
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
 payloads/libpayload/drivers/usb/ehci.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/payloads/libpayload/drivers/usb/ehci.c b/payloads/libpayload/drivers/usb/ehci.c
index 3e5de1d..5af99e0 100644
--- a/payloads/libpayload/drivers/usb/ehci.c
+++ b/payloads/libpayload/drivers/usb/ehci.c
@@ -27,6 +27,8 @@
+//#define USB_DEBUG
 #include <libpayload.h>
 #include "ehci.h"
 #include "ehci_private.h"
@@ -67,6 +69,7 @@ static void dump_td(u32 addr)
+#ifdef USB_DEBUG
 static void dump_qh(ehci_qh_t *cur)
 	qtd_t *tmp_qtd = NULL;
@@ -112,6 +115,7 @@ static void dump_qh(ehci_qh_t *cur)
 static void ehci_start (hci_t *controller)

More information about the coreboot-gerrit mailing list