[coreboot-gerrit] New patch to review for coreboot: a11a804 ASRock E350M1: get_bus_conf.c: Include `agesawrapper.h` for `agesawrapper_amdinitlate`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Fri Mar 29 13:48:43 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2955

-gerrit

commit a11a80444dc6b4da6e230fe05b8b43c9d319f427
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Mar 29 13:23:31 2013 +0100

    ASRock E350M1: get_bus_conf.c: Include `agesawrapper.h` for `agesawrapper_amdinitlate`
    
    When building the ASRock E350M1, the following warning is shown.
    
        $ make # on Jenkins (build server)
        […]
            CC         mainboard/asrock/e350m1/get_bus_conf.ramstage.o
        src/mainboard/asrock/e350m1/get_bus_conf.c: In function 'get_bus_conf':
        src/mainboard/asrock/e350m1/get_bus_conf.c:82:3: warning: implicit declaration of function 'agesawrapper_amdinitlate' [-Wimplicit-function-declaration]
        […]
    
    Including the header file `agesawrapper.h` declaring the function
    `agesawrapper_amdinitlate` fixes this warning.
    
    All AMD Family 14 based boards already include that header file. For
    example for the board AMD Persimmon the following patch fixed this
    warning.
    
        commit d7a696d0f229abccc95ff411f28d91b9b796ab74
        Author: efdesign98 <efdesign98 at gmail.com>
        Date:   Thu Sep 15 15:24:26 2011 -0600
    
            Persimmon updates for AMD F14 rev C0
    
            Reviewed-on: http://review.coreboot.org/137
    
    Change-Id: I695420b7071e07cb7d4667b2479b9a26ea13723d
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/asrock/e350m1/get_bus_conf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mainboard/asrock/e350m1/get_bus_conf.c b/src/mainboard/asrock/e350m1/get_bus_conf.c
index c2034f8..1419d79 100644
--- a/src/mainboard/asrock/e350m1/get_bus_conf.c
+++ b/src/mainboard/asrock/e350m1/get_bus_conf.c
@@ -24,6 +24,7 @@
 #include <stdint.h>
 #include <stdlib.h>
 #include <cpu/amd/amdfam14.h>
+#include "agesawrapper.h"
 #if CONFIG_AMD_SB_CIMX
 #include "sb_cimx.h"
 #endif



More information about the coreboot-gerrit mailing list