[coreboot-gerrit] Patch set updated for coreboot: fbb859b ASRock E350M1: irq_tables.c: Include `cpu/amd/amdfam14.h` for `get_bus_conf`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Fri Mar 29 20:57:36 CET 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2956


commit fbb859bb38c6f87c0de1489589aa195049958f4c
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Fri Mar 29 14:36:33 2013 +0100

    ASRock E350M1: irq_tables.c: Include `cpu/amd/amdfam14.h` for `get_bus_conf`
    When building the ASRock E350M1, the following warning is shown.
        $ make # on Jenkins (build server)
            CC         mainboard/asrock/e350m1/irq_tables.ramstage.o
        src/mainboard/asrock/e350m1/irq_tables.c: In function 'write_pirq_routing_table':
        src/mainboard/asrock/e350m1/irq_tables.c:64:2: warning: implicit declaration of function 'get_bus_conf' [-Wimplicit-function-declaration]
    Including the header file `cpu/amd/amdfam14.h` declaring the
    function addresses this warning.
    The same change was done in the following commit for the
    AMD Persimmon board.
        commit d7a696d0f229abccc95ff411f28d91b9b796ab74
        Author: efdesign98 <efdesign98 at gmail.com>
        Date:   Thu Sep 15 15:24:26 2011 -0600
            Persimmon updates for AMD F14 rev C0
            Reviewed-on: http://review.coreboot.org/137
    Change-Id: I40b5735feb7116961ca0c4d6940ec55cdf42d3c6
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/mainboard/asrock/e350m1/irq_tables.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/mainboard/asrock/e350m1/irq_tables.c b/src/mainboard/asrock/e350m1/irq_tables.c
index 6bb9911..5323d44 100644
--- a/src/mainboard/asrock/e350m1/irq_tables.c
+++ b/src/mainboard/asrock/e350m1/irq_tables.c
@@ -23,8 +23,7 @@
 #include <string.h>
 #include <stdint.h>
 #include <arch/pirq_routing.h>
-//#include <cpu/amd/amdfam10_sysconf.h>
+#include <cpu/amd/amdfam14.h>
 static void write_pirq_info(struct irq_info *pirq_info, u8 bus, u8 devfn,

More information about the coreboot-gerrit mailing list