[coreboot-gerrit] Patch set updated for coreboot: 87b1437 x86 I/O APIC: Dump I/O APIC regs in `ioapic.c`

[Paul Menzel (paulepanter@users.sourceforge.net)]

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3184

-gerrit

commit 87b1437498306814711c646899d3377c8f896d65
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Tue Apr 23 14:49:41 2013 +0200

    x86 I/O APIC: Dump I/O APIC regs in `ioapic.c`
    
    Some southbridges have code in their `lpc.c` files to dump the
    I/O APIC registers.
    
        printk(BIOS_SPEW, "Dumping IOAPIC registers\n");
        for (i=0; i<3; i++) {
                *ioapic_index = i;
                printk(BIOS_SPEW, "  reg 0x%04x:", i);
                reg32 = *ioapic_data;
                printk(BIOS_SPEW, " 0x%08x\n", reg32);
        }
    
    Add similar code to `src/arch/x86/lib/ioapic.c` so all boards using
    the function `set_ioapic_id()` get the debug feature and the other
    boards can be more easily adapted in follow-up patches.
    
    Change-Id: Ic59c4c2213ed97bdf3798b3dc6e7cecc30e135d8
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/arch/x86/lib/ioapic.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/arch/x86/lib/ioapic.c b/src/arch/x86/lib/ioapic.c
index 4964af6..7fb25ba 100644
--- a/src/arch/x86/lib/ioapic.c
+++ b/src/arch/x86/lib/ioapic.c
@@ -77,6 +77,7 @@ void clear_ioapic(u32 ioapic_base)
 void set_ioapic_id(u32 ioapic_base, u8 ioapic_id)
 {
 	u32 bsp_lapicid = lapicid();
+	int i;
 
 	printk(BIOS_DEBUG, "IOAPIC: Initializing IOAPIC at 0x%08x\n",
 	       ioapic_base);
@@ -90,6 +91,12 @@ void set_ioapic_id(u32 ioapic_base, u8 ioapic_id)
 			(io_apic_read(ioapic_base, 0x00) & 0xf0ffffff) |
 			(ioapic_id << 24));
 	}
+
+	printk(BIOS_SPEW, "IOAPIC: Dumping registers\n");
+	for (i = 0; i < 3; i++)
+		printk(BIOS_SPEW, "  reg 0x%04x: 0x%08x\n", i,
+		       io_apic_read(ioapic_base, i));
+
 }
 
 static void load_vectors(u32 ioapic_base)