[coreboot-gerrit] New patch to review for coreboot: 0ce91c8 northbridge: i945: Switch to automatic resource numbering.

Denis Carikli (GNUtoo@no-log.org) gerrit at coreboot.org
Fri May 24 17:26:33 CEST 2013


Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3280

-gerrit

commit 0ce91c83ed7a41ad71283bfba22d35b2a36f561b
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date:   Fri May 24 02:51:06 2013 +0200

    northbridge: i945: Switch to automatic resource numbering.
    
    Change-Id: I7148669147a5823347d608d87f88b2b813060436
    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
 src/northbridge/intel/i945/northbridge.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/northbridge/intel/i945/northbridge.c b/src/northbridge/intel/i945/northbridge.c
index fd4b02a..154b293 100644
--- a/src/northbridge/intel/i945/northbridge.c
+++ b/src/northbridge/intel/i945/northbridge.c
@@ -93,6 +93,7 @@ static void pci_domain_set_resources(device_t dev)
 	uint16_t reg16;
 	unsigned long long tomk, tomk_stolen;
 	uint64_t tseg_memory_base = 0, tseg_memory_size = 0;
+	unsigned long index = 3;
 
 	/* Can we find out how much memory we can use at most
 	 * this way?
@@ -166,12 +167,12 @@ static void pci_domain_set_resources(device_t dev)
 	printk(BIOS_INFO, " (%dM)\n", (uint32_t)(tomk_stolen >> 10));
 
 	/* Report the memory regions */
-	ram_resource(dev, 3, 0, 640);
-	ram_resource(dev, 4, 768, (tomk - 768));
-	uma_resource(dev, 5, uma_memory_base >> 10, uma_memory_size >> 10);
-	mmio_resource(dev, 6, tseg_memory_base >> 10, tseg_memory_size >> 10);
+	ram_resource(dev, index++, 0, 640);
+	ram_resource(dev, index++, 768, (tomk - 768));
+	uma_resource(dev, index++, uma_memory_base >> 10, uma_memory_size >> 10);
+	mmio_resource(dev, index++, tseg_memory_base >> 10, tseg_memory_size >> 10);
 
-	add_fixed_resources(dev, 7);
+	add_fixed_resources(dev, index);
 
 	assign_resources(dev->link_list);
 
@@ -182,7 +183,7 @@ static void pci_domain_set_resources(device_t dev)
 	graphics_ram_resource_base = ( high_tables_base - (4 * 1024 * 1024) );
 	graphics_ram_resource_size = (4 * 1024 * 1024);
 
-	reserved_ram_resource(dev, 8, graphics_ram_resource_base >> 10,
+	reserved_ram_resource(dev, index++, graphics_ram_resource_base >> 10,
 				graphics_ram_resource_size >> 10);
 #endif
 }



More information about the coreboot-gerrit mailing list