[coreboot-gerrit] Patch set updated for coreboot: da9dfd4 Provide sane Kconfig default for cmos.default.
Denis Carikli (GNUtoo@no-log.org)
gerrit at coreboot.org
Wed May 29 21:54:09 CEST 2013
Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3223
-gerrit
commit da9dfd48fb99f9908b5849ff71ffb4c3bed0ce24
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date: Tue May 28 13:46:12 2013 +0200
Provide sane Kconfig default for cmos.default.
Without that fix we have with CONFIG_USE_OPTION_TABLE:
OPTION cmos_layout.bin
build/util/nvramtool/nvramtool -y /home/gnutoo/x86/coreboot-alix/src/mainboard/pcengines/alix1c/cmos.layout -L build/cmos_layout.bin
make: *** No rule to make target `nvramtool', needed by `build/coreboot.pre1'. Stop.
rm build/util/sconfig/sconfig.tab.c build/cbfs/fallback/bootblock.elf build/util/sconfig/lex.yy.c
That log was captured with make V=1 but the error also appear with make.
This commit was tested on the PC Engines ALIX.1C with the following commit:
PC Engines ALIX.1C: Add CMOS defaults.
Change-Id: I548005a58f430ed7b6da5249a24bbdcae440a1e9
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
src/arch/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 5f46145..c7b2434 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -81,6 +81,7 @@ config HAVE_CMOS_DEFAULT
config CMOS_DEFAULT_FILE
string
+ default "src/mainboard/$(MAINBOARDDIR)/cmos.default"
depends on HAVE_CMOS_DEFAULT
config BOOTBLOCK_SOUTHBRIDGE_INIT
More information about the coreboot-gerrit
mailing list