[coreboot-gerrit] Patch merged into coreboot/master: 0390112 AMD Parmer: fix issue 'S3 fails to suspend after wake up from USB keyboard'

gerrit at coreboot.org gerrit at coreboot.org
Fri May 31 17:50:55 CEST 2013


the following patch was just integrated into master:
commit 0390112407c042211428a2aee1ab77422caab338
Author: Siyuan Wang <wangsiyuanbuaa at gmail.com>
Date:   Fri May 31 19:36:30 2013 +0800

    AMD Parmer: fix issue 'S3 fails to suspend after wake up from USB keyboard'
    
    This issue can be reproduced in Linux by the following steps:
    1) use pm-suspend to suspend.
    2) use USB keyboard to wake up.
    3) use pm-suspend to suspend. FAIL To SUSPEND.
    
    The cause of this issue is:
    USB devices use bit 11(0x0b) of GP0_STS represents S3 wake up event,
    but this bit is not clear after wake up. So OS thinks there is a
    wake up signal and wake up immediately.
    
    In this patch, I add AcpiGpe0Blk using MMIO access and write 1
    on bit 11. I have tested on Parmer.
    
    Change-Id: Iec3078bf29de99683e7cd3ef4e178fbeb4dc09c1
    Signed-off-by: Siyuan Wang <SiYuan.Wang at amd.com>
    Signed-off-by: Siyuan Wang <wangsiyuanbuaa at gmail.com>
    Reviewed-on: http://review.coreboot.org/3347
    Tested-by: build bot (Jenkins)
    Reviewed-by: Dave Frodin <dave.frodin at se-eng.com>
    Reviewed-by: Marc Jones <marc.jones at se-eng.com>
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>


See http://review.coreboot.org/3347 for details.

-gerrit



More information about the coreboot-gerrit mailing list