[coreboot-gerrit] New patch to review for coreboot: df05ad5 call fill_lb_framebuffer() earlier

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Nov 19 00:44:11 CET 2013

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4155


commit df05ad55d799dc7dab9eb9bbdf91e5dac83b06a4
Author: David Hendricks <dhendrix at chromium.org>
Date:   Thu May 2 18:23:24 2013 -0700

    call fill_lb_framebuffer() earlier
    fill_lb_framebuffer() now sets the framebuffer pointer according to
    the EDID information, so it must be called before setting the tag
    and size.
    (credit to rminnich for this, I'm just uploading it)
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Change-Id: I5ac783fa3a776eee504d39889284041d1dc2c92a
    Reviewed-on: https://gerrit.chromium.org/gerrit/50012
    Reviewed-by: Gabe Black <gabeblack at chromium.org>
    Commit-Queue: David Hendricks <dhendrix at chromium.org>
    Tested-by: David Hendricks <dhendrix at chromium.org>
 src/lib/coreboot_table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index e5729ba..a0a806d 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -177,9 +177,9 @@ static void lb_framebuffer(struct lb_header *header)
 	struct lb_framebuffer *framebuffer;
 	framebuffer = (struct lb_framebuffer *)lb_new_record(header);
+	fill_lb_framebuffer(framebuffer);
 	framebuffer->tag = LB_TAG_FRAMEBUFFER;
 	framebuffer->size = sizeof(*framebuffer);
-	fill_lb_framebuffer(framebuffer);

More information about the coreboot-gerrit mailing list