[coreboot-gerrit] New patch to review for coreboot: 7366469 slippy: Run EC init as part of mainboard init step

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Nov 19 00:58:17 CET 2013

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4178


commit 736646929654cc598e81d0a7ed350d21ce88fcb5
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue May 21 10:11:07 2013 -0700

    slippy: Run EC init as part of mainboard init step
    This will log and clear EC events so they do not take effect
    when the SMI handler is enabled.
    Change-Id: I5ef563f7cedc8977410cc3f69e2655fc4e14c9eb
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/56055
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
 src/mainboard/google/slippy/mainboard.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/mainboard/google/slippy/mainboard.c b/src/mainboard/google/slippy/mainboard.c
index c91be19..c13d0bb 100644
--- a/src/mainboard/google/slippy/mainboard.c
+++ b/src/mainboard/google/slippy/mainboard.c
@@ -35,6 +35,7 @@
 #include <boot/coreboot_tables.h>
 #include "hda_verb.h"
 #include <southbridge/intel/lynxpoint/pch.h>
+#include "ec.h"
 void mainboard_suspend_resume(void)
@@ -139,11 +140,17 @@ static void verb_setup(void)
 	cim_verb_data_size = sizeof(mainboard_cim_verb_data);
+static void mainboard_init(device_t dev)
+	slippy_ec_init();
 // mainboard_enable is executed as first thing after
 // enumerate_buses().
 static void mainboard_enable(device_t dev)
+	dev->ops->init = mainboard_init;
 	/* Install custom int15 handler for VGA OPROM */
 	mainboard_interrupt_handlers(0x15, &int15_handler);

More information about the coreboot-gerrit mailing list