[coreboot-gerrit] New patch to review for coreboot: a14b459 lynxpoint: Do not clear ACPI NVS region on resume

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Wed Nov 20 01:32:40 CET 2013

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4210


commit a14b4597f1c502a462afb379c2ecc53bb5157c3a
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed May 29 07:49:55 2013 -0700

    lynxpoint: Do not clear ACPI NVS region on resume
    There are useful values in NVS that are set at boot
    and runtime and they should not be cleared on resume.
    suspend/resume twice on slippy and ensure
    that the USB ports are still powered on the second suspend.
    Change-Id: I4bce60b02b6637f6683120ae9c4a5c64563aacf7
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/56941
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
 src/southbridge/intel/lynxpoint/lpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c
index ff50476..cc95454 100644
--- a/src/southbridge/intel/lynxpoint/lpc.c
+++ b/src/southbridge/intel/lynxpoint/lpc.c
@@ -701,7 +701,7 @@ static void pch_lpc_read_resources(device_t dev)
 	/* Allocate ACPI NVS in CBMEM */
 	gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof(global_nvs_t));
-	if (gnvs)
+	if (acpi_slp_type != 3 && gnvs)
 		memset(gnvs, 0, sizeof(global_nvs_t));

More information about the coreboot-gerrit mailing list