[coreboot-gerrit] New patch to review for coreboot: 2c0600f vboot: Do not pass OPROM_MATTERS flag to VbInit

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Wed Nov 20 01:33:13 CET 2013

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4222


commit 2c0600f18eca4db689da9540924f05af796582f1
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Jun 4 10:08:54 2013 -0700

    vboot: Do not pass OPROM_MATTERS flag to VbInit
    Since we are using VBNV to determine if developer mode is
    active we do not need the messy OPROM hook magic any longer.
    Change-Id: I1b9effef3ef2aa84e916060d8e61ee42515a2b7c
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/57473
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
 src/vendorcode/google/chromeos/gnvs.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/src/vendorcode/google/chromeos/gnvs.c b/src/vendorcode/google/chromeos/gnvs.c
index ba1588d..5ee3665 100644
--- a/src/vendorcode/google/chromeos/gnvs.c
+++ b/src/vendorcode/google/chromeos/gnvs.c
@@ -49,15 +49,9 @@ void chromeos_init_vboot(chromeos_acpi_t *chromeos)
 	vboot_handoff = cbmem_find(CBMEM_ID_VBOOT_HANDOFF);
-	if (vboot_handoff != NULL) {
-		vboot_handoff->init_params.flags |= VB_INIT_FLAG_OPROM_MATTERS;
-		if (oprom_is_loaded)
-			vboot_handoff->init_params.flags |=
+	if (vboot_handoff != NULL)
 		memcpy(&chromeos->vdat[0], &vboot_handoff->shared_data[0],
-	}

More information about the coreboot-gerrit mailing list