[coreboot-gerrit] New patch to review for coreboot: dcf3ec8 libpayload: fix wrong endian assumption in sha1.c

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Wed Nov 20 02:22:04 CET 2013

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4236


commit dcf3ec8f2724994dc6a12e8260bcb488270a9411
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Tue May 21 10:46:28 2013 -0700

    libpayload: fix wrong endian assumption in sha1.c
    Not all platforms !x86 are big endian, hence actually look
    at the CONFIG_LITTLE_ENDIAN flag instead of CONFIG_ARCH_X86.
    Change-Id: Ibbd8f48b377a1121dd1e045834a94a2d67eda2ab
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/56066
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>
    Reviewed-by: Ronald G. Minnich <rminnich at chromium.org>
    Commit-Queue: Stefan Reinauer <reinauer at chromium.org>
    Tested-by: Stefan Reinauer <reinauer at chromium.org>
 payloads/libpayload/crypto/sha1.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/payloads/libpayload/crypto/sha1.c b/payloads/libpayload/crypto/sha1.c
index 3c97bf1..c973e18 100644
--- a/payloads/libpayload/crypto/sha1.c
+++ b/payloads/libpayload/crypto/sha1.c
@@ -30,18 +30,12 @@ typedef unsigned int u_int;
 /* Moved from libpayload.h */
-#ifdef CONFIG_ARCH_X86
-#if 0
-#include <sys/param.h>
-#include <string.h>
-#include <sha1.h>
 #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - (bits))))

More information about the coreboot-gerrit mailing list